Rename GetElementValue() to GetDirectObject{By,At}().

core/fpdfapi/fpdf_parser/cpdf_dictionary.cpp

 // Copyright 2016 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/fpdfapi/fpdf_parser/include/cpdf_dictionary.h"
 
 #include "core/fpdfapi/fpdf_parser/cpdf_boolean.h"
 #include "core/fpdfapi/fpdf_parser/include/cpdf_array.h"
@@ skipping 33 matching lines @@
   return this;
 }
 
 CPDF_Object* CPDF_Dictionary::Clone(FX_BOOL bDirect) const {
   CPDF_Dictionary* pCopy = new CPDF_Dictionary();
   for (const auto& it : *this)
     pCopy->m_Map.insert(std::make_pair(it.first, it.second->Clone(bDirect)));
   return pCopy;
 }
 
-CPDF_Object* CPDF_Dictionary::GetElement(const CFX_ByteStringC& key) const {
+CPDF_Object* CPDF_Dictionary::GetObjectBy(const CFX_ByteStringC& key) const {
   auto it = m_Map.find(key);
   if (it == m_Map.end())
     return nullptr;
   return it->second;
 }
-CPDF_Object* CPDF_Dictionary::GetElementValue(
+CPDF_Object* CPDF_Dictionary::GetDirectObjectBy(
     const CFX_ByteStringC& key) const {
-  CPDF_Object* p = GetElement(key);
+  CPDF_Object* p = GetObjectBy(key);
   return p ? p->GetDirect() : nullptr;
 }
 
 CFX_ByteString CPDF_Dictionary::GetStringBy(const CFX_ByteStringC& key) const {
-  CPDF_Object* p = GetElement(key);
+  CPDF_Object* p = GetObjectBy(key);
   return p ? p->GetString() : CFX_ByteString();
 }
 
 CFX_ByteStringC CPDF_Dictionary::GetConstStringBy(
     const CFX_ByteStringC& key) const {
-  CPDF_Object* p = GetElement(key);
+  CPDF_Object* p = GetObjectBy(key);
   return p ? p->GetConstString() : CFX_ByteStringC();
 }
 
 CFX_WideString CPDF_Dictionary::GetUnicodeTextBy(
     const CFX_ByteStringC& key) const {
-  CPDF_Object* p = GetElement(key);
+  CPDF_Object* p = GetObjectBy(key);
   if (CPDF_Reference* pRef = ToReference(p))
     p = pRef->GetDirect();
   return p ? p->GetUnicodeText() : CFX_WideString();
 }
 
 CFX_ByteString CPDF_Dictionary::GetStringBy(const CFX_ByteStringC& key,
                                             const CFX_ByteStringC& def) const {
-  CPDF_Object* p = GetElement(key);
+  CPDF_Object* p = GetObjectBy(key);
   return p ? p->GetString() : CFX_ByteString(def);
 }
 
 CFX_ByteStringC CPDF_Dictionary::GetConstStringBy(
     const CFX_ByteStringC& key,
     const CFX_ByteStringC& def) const {
-  CPDF_Object* p = GetElement(key);
+  CPDF_Object* p = GetObjectBy(key);
   return p ? p->GetConstString() : CFX_ByteStringC(def);
 }
 
 int CPDF_Dictionary::GetIntegerBy(const CFX_ByteStringC& key) const {
-  CPDF_Object* p = GetElement(key);
+  CPDF_Object* p = GetObjectBy(key);
   return p ? p->GetInteger() : 0;
 }
 
 int CPDF_Dictionary::GetIntegerBy(const CFX_ByteStringC& key, int def) const {
-  CPDF_Object* p = GetElement(key);
+  CPDF_Object* p = GetObjectBy(key);
   return p ? p->GetInteger() : def;
 }
 
 FX_FLOAT CPDF_Dictionary::GetNumberBy(const CFX_ByteStringC& key) const {
-  CPDF_Object* p = GetElement(key);
+  CPDF_Object* p = GetObjectBy(key);
   return p ? p->GetNumber() : 0;
 }
 
 FX_BOOL CPDF_Dictionary::GetBooleanBy(const CFX_ByteStringC& key,
                                       FX_BOOL bDefault) const {
-  CPDF_Object* p = GetElement(key);
+  CPDF_Object* p = GetObjectBy(key);
   return ToBoolean(p) ? p->GetInteger() : bDefault;
 }
 
 CPDF_Dictionary* CPDF_Dictionary::GetDictBy(const CFX_ByteStringC& key) const {
-  CPDF_Object* p = GetElementValue(key);
+  CPDF_Object* p = GetDirectObjectBy(key);
   if (!p)
     return nullptr;
   if (CPDF_Dictionary* pDict = p->AsDictionary())
     return pDict;
   if (CPDF_Stream* pStream = p->AsStream())
     return pStream->GetDict();
   return nullptr;
 }
 
 CPDF_Array* CPDF_Dictionary::GetArrayBy(const CFX_ByteStringC& key) const {
-  return ToArray(GetElementValue(key));
+  return ToArray(GetDirectObjectBy(key));
 }
 
 CPDF_Stream* CPDF_Dictionary::GetStreamBy(const CFX_ByteStringC& key) const {
-  return ToStream(GetElementValue(key));
+  return ToStream(GetDirectObjectBy(key));
 }
 
 CFX_FloatRect CPDF_Dictionary::GetRectBy(const CFX_ByteStringC& key) const {
   CFX_FloatRect rect;
   CPDF_Array* pArray = GetArrayBy(key);
   if (pArray)
     rect = pArray->GetRect();
   return rect;
 }
 
 CFX_Matrix CPDF_Dictionary::GetMatrixBy(const CFX_ByteStringC& key) const {
   CFX_Matrix matrix;
   CPDF_Array* pArray = GetArrayBy(key);
   if (pArray)
     matrix = pArray->GetMatrix();
   return matrix;
 }
 
 FX_BOOL CPDF_Dictionary::KeyExist(const CFX_ByteStringC& key) const {
   return pdfium::ContainsKey(m_Map, key);
 }
 
 bool CPDF_Dictionary::IsSignatureDict() const {
-  CPDF_Object* pType = GetElementValue("Type");
+  CPDF_Object* pType = GetDirectObjectBy("Type");
   if (!pType)
-    pType = GetElementValue("FT");
+    pType = GetDirectObjectBy("FT");
   return pType && pType->GetString() == "Sig";
 }
 
 void CPDF_Dictionary::SetAt(const CFX_ByteStringC& key, CPDF_Object* pObj) {
   ASSERT(IsDictionary());
   // Avoid 2 constructions of CFX_ByteString.
   CFX_ByteString key_bytestring = key;
   auto it = m_Map.find(key_bytestring);
   if (it == m_Map.end()) {
     if (pObj)
@@ skipping 90 matching lines @@
                                   const CFX_Matrix& matrix) {
   CPDF_Array* pArray = new CPDF_Array;
   pArray->AddNumber(matrix.a);
   pArray->AddNumber(matrix.b);
   pArray->AddNumber(matrix.c);
   pArray->AddNumber(matrix.d);
   pArray->AddNumber(matrix.e);
   pArray->AddNumber(matrix.f);
   SetAt(key, pArray);
 }