Rename GetElementValue() to GetDirectObject{By,At}().

core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp

 // Copyright 2016 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/fpdfapi/fpdf_parser/cpdf_hint_tables.h"
 
 #include "core/fpdfapi/fpdf_parser/cpdf_data_avail.h"
 #include "core/fpdfapi/fpdf_parser/include/cpdf_array.h"
@@ skipping 84 matching lines @@
 
   // Item 12: The number of bits needed to represent the numerator of
   // the fractional position for each shared object reference. For each
   // shared object referenced from a page, there is an indication of
   // where in the page's content stream the object is first referenced.
   uint32_t dwSharedNumeratorBits = hStream->GetBits(16);
 
   // Item 13: Skip Item 13 which has 16 bits.
   hStream->SkipBits(16);
 
-  CPDF_Object* pPageNum = m_pLinearizedDict->GetElementValue("N");
+  CPDF_Object* pPageNum = m_pLinearizedDict->GetDirectObjectBy("N");
   int nPages = pPageNum ? pPageNum->GetInteger() : 0;
   if (nPages < 1)
     return FALSE;
 
   FX_SAFE_DWORD required_bits = dwDeltaObjectsBits;
   required_bits *= pdfium::base::checked_cast<uint32_t>(nPages);
   if (!CanReadFromBitStream(hStream, required_bits))
     return FALSE;
 
   for (int i = 0; i < nPages; ++i) {
@@ skipping 12 matching lines @@
 
   CFX_ArrayTemplate<uint32_t> dwPageLenArray;
   for (int i = 0; i < nPages; ++i) {
     FX_SAFE_DWORD safePageLen = hStream->GetBits(dwDeltaPageLenBits);
     safePageLen += dwPageLeastLen;
     if (!safePageLen.IsValid())
       return FALSE;
     dwPageLenArray.Add(safePageLen.ValueOrDie());
   }
 
-  CPDF_Object* pOffsetE = m_pLinearizedDict->GetElementValue("E");
+  CPDF_Object* pOffsetE = m_pLinearizedDict->GetDirectObjectBy("E");
   int nOffsetE = pOffsetE ? pOffsetE->GetInteger() : -1;
   if (nOffsetE < 0)
     return FALSE;
 
-  CPDF_Object* pFirstPageNum = m_pLinearizedDict->GetElementValue("P");
+  CPDF_Object* pFirstPageNum = m_pLinearizedDict->GetDirectObjectBy("P");
   int nFirstPageNum = pFirstPageNum ? pFirstPageNum->GetInteger() : 0;
   for (int i = 0; i < nPages; ++i) {
     if (i == nFirstPageNum) {
       m_szPageOffsetArray.push_back(m_szFirstPageObjOffset);
     } else if (i == nFirstPageNum + 1) {
       if (i == 1) {
         m_szPageOffsetArray.push_back(nOffsetE);
       } else {
         m_szPageOffsetArray.push_back(m_szPageOffsetArray[i - 2] +
                                       dwPageLenArray[i - 2]);
@@ skipping 95 matching lines @@
   // Item 5: The number of bits needed to represent the greatest number of
   // objects in a shared object group. Skipped.
   hStream->SkipBits(16);
 
   // Item 6: The least length of a shared object group in bytes.
   uint32_t dwGroupLeastLen = hStream->GetBits(32);
 
   // Item 7: The number of bits needed to represent the difference between the
   // greatest and least length of a shared object group, in bytes.
   uint32_t dwDeltaGroupLen = hStream->GetBits(16);
-  CPDF_Object* pFirstPageObj = m_pLinearizedDict->GetElementValue("O");
+  CPDF_Object* pFirstPageObj = m_pLinearizedDict->GetDirectObjectBy("O");
   int nFirstPageObjNum = pFirstPageObj ? pFirstPageObj->GetInteger() : -1;
   if (nFirstPageObjNum < 0)
     return FALSE;
 
   uint32_t dwPrevObjLen = 0;
   uint32_t dwCurObjLen = 0;
   FX_SAFE_DWORD required_bits = dwSharedObjTotal;
   required_bits *= dwDeltaGroupLen;
   if (!CanReadFromBitStream(hStream, required_bits))
     return FALSE;
@@ skipping 54 matching lines @@
 FX_BOOL CPDF_HintTables::GetPagePos(int index,
                                     FX_FILESIZE& szPageStartPos,
                                     FX_FILESIZE& szPageLength,
                                     uint32_t& dwObjNum) {
   if (!m_pLinearizedDict)
     return FALSE;
 
   szPageStartPos = m_szPageOffsetArray[index];
   szPageLength = GetItemLength(index, m_szPageOffsetArray);
 
-  CPDF_Object* pFirstPageNum = m_pLinearizedDict->GetElementValue("P");
+  CPDF_Object* pFirstPageNum = m_pLinearizedDict->GetDirectObjectBy("P");
   int nFirstPageNum = pFirstPageNum ? pFirstPageNum->GetInteger() : 0;
 
-  CPDF_Object* pFirstPageObjNum = m_pLinearizedDict->GetElementValue("O");
+  CPDF_Object* pFirstPageObjNum = m_pLinearizedDict->GetDirectObjectBy("O");
   if (!pFirstPageObjNum)
     return FALSE;
 
   int nFirstPageObjNum = pFirstPageObjNum->GetInteger();
   if (index == nFirstPageNum) {
     dwObjNum = nFirstPageObjNum;
     return TRUE;
   }
 
   // The object number of remaining pages starts from 1.
   dwObjNum = 1;
   for (int i = 0; i < index; ++i) {
     if (i == nFirstPageNum)
       continue;
     dwObjNum += m_dwDeltaNObjsArray[i];
   }
   return TRUE;
 }
 
 IPDF_DataAvail::DocAvailStatus CPDF_HintTables::CheckPage(
     int index,
     IPDF_DataAvail::DownloadHints* pHints) {
   if (!m_pLinearizedDict || !pHints)
     return IPDF_DataAvail::DataError;
 
-  CPDF_Object* pFirstAvailPage = m_pLinearizedDict->GetElementValue("P");
+  CPDF_Object* pFirstAvailPage = m_pLinearizedDict->GetDirectObjectBy("P");
   int nFirstAvailPage = pFirstAvailPage ? pFirstAvailPage->GetInteger() : 0;
   if (index == nFirstAvailPage)
     return IPDF_DataAvail::DataAvailable;
 
   uint32_t dwLength = GetItemLength(index, m_szPageOffsetArray);
   // If two pages have the same offset, it should be treated as an error.
   if (!dwLength)
     return IPDF_DataAvail::DataError;
 
   if (!m_pDataAvail->IsDataAvail(m_szPageOffsetArray[index], dwLength, pHints))
     return IPDF_DataAvail::DataNotAvailable;
 
   // Download data of shared objects in the page.
   uint32_t offset = 0;
   for (int i = 0; i < index; ++i)
     offset += m_dwNSharedObjsArray[i];
 
-  CPDF_Object* pFirstPageObj = m_pLinearizedDict->GetElementValue("O");
+  CPDF_Object* pFirstPageObj = m_pLinearizedDict->GetDirectObjectBy("O");
   int nFirstPageObjNum = pFirstPageObj ? pFirstPageObj->GetInteger() : -1;
   if (nFirstPageObjNum < 0)
     return IPDF_DataAvail::DataError;
 
   uint32_t dwIndex = 0;
   uint32_t dwObjNum = 0;
   for (uint32_t j = 0; j < m_dwNSharedObjsArray[index]; ++j) {
     dwIndex = m_dwIdentifierArray[offset + j];
     if (dwIndex >= m_dwSharedObjNumArray.GetSize())
       return IPDF_DataAvail::DataNotAvailable;
@@ skipping 15 matching lines @@
     }
   }
   return IPDF_DataAvail::DataAvailable;
 }
 
 FX_BOOL CPDF_HintTables::LoadHintStream(CPDF_Stream* pHintStream) {
   if (!pHintStream || !m_pLinearizedDict)
     return FALSE;
 
   CPDF_Dictionary* pDict = pHintStream->GetDict();
-  CPDF_Object* pOffset = pDict ? pDict->GetElement("S") : nullptr;
+  CPDF_Object* pOffset = pDict ? pDict->GetObjectBy("S") : nullptr;
   if (!pOffset || !pOffset->IsNumber())
     return FALSE;
 
   int shared_hint_table_offset = pOffset->GetInteger();
   CPDF_StreamAcc acc;
   acc.LoadAllData(pHintStream);
 
   uint32_t size = acc.GetSize();
   // The header section of page offset hint table is 36 bytes.
   // The header section of shared object hint table is 24 bytes.
@@ skipping 12 matching lines @@
 }
 
 int CPDF_HintTables::ReadPrimaryHintStreamOffset() const {
   if (!m_pLinearizedDict)
     return -1;
 
   CPDF_Array* pRange = m_pLinearizedDict->GetArrayBy("H");
   if (!pRange)
     return -1;
 
-  CPDF_Object* pStreamOffset = pRange->GetElementValue(0);
+  CPDF_Object* pStreamOffset = pRange->GetDirectObjectAt(0);
   if (!pStreamOffset)
     return -1;
 
   return pStreamOffset->GetInteger();
 }
 
 int CPDF_HintTables::ReadPrimaryHintStreamLength() const {
   if (!m_pLinearizedDict)
     return -1;
 
   CPDF_Array* pRange = m_pLinearizedDict->GetArrayBy("H");
   if (!pRange)
     return -1;
 
-  CPDF_Object* pStreamLen = pRange->GetElementValue(1);
+  CPDF_Object* pStreamLen = pRange->GetDirectObjectAt(1);
   if (!pStreamLen)
     return -1;
 
   return pStreamLen->GetInteger();
 }