Rename GetElementValue() to GetDirectObject{By,At}().

core/fpdfdoc/doc_formfield.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/fpdfapi/fpdf_parser/include/cfdf_document.h"
 #include "core/fpdfapi/fpdf_parser/include/cpdf_array.h"
 #include "core/fpdfapi/fpdf_parser/include/cpdf_document.h"
 #include "core/fpdfapi/fpdf_parser/include/cpdf_number.h"
@@ skipping 287 matching lines @@
     }
     if (!pValue) {
       return CFX_WideString();
     }
   }
   switch (pValue->GetType()) {
     case CPDF_Object::STRING:
     case CPDF_Object::STREAM:
       return pValue->GetUnicodeText();
     case CPDF_Object::ARRAY:
-      pValue = pValue->AsArray()->GetElementValue(0);
+      pValue = pValue->AsArray()->GetDirectObjectAt(0);
       if (pValue)
         return pValue->GetUnicodeText();
       break;
     default:
       break;
   }
   return CFX_WideString();
 }
 CFX_WideString CPDF_FormField::GetValue() {
   return GetValue(FALSE);
@@ skipping 121 matching lines @@
   CFX_WideString sel_value;
   if (pValue->IsString()) {
     if (index != 0)
       return -1;
     sel_value = pValue->GetUnicodeText();
   } else {
     CPDF_Array* pArray = pValue->AsArray();
     if (!pArray || index < 0)
       return -1;
 
-    CPDF_Object* elementValue = pArray->GetElementValue(index);
+    CPDF_Object* elementValue = pArray->GetDirectObjectAt(index);
     sel_value =
         elementValue ? elementValue->GetUnicodeText() : CFX_WideString();
   }
   if (index < CountSelectedOptions()) {
     int iOptIndex = GetSelectedOptionIndex(index);
     CFX_WideString csOpt = GetOptionValue(iOptIndex);
     if (csOpt == sel_value) {
       return iOptIndex;
     }
   }
@@ skipping 70 matching lines @@
     return FALSE;
 
   int iPos = -1;
   for (int j = 0; j < CountSelectedOptions(); j++) {
     if (GetSelectedOptionIndex(j) == index) {
       iPos = j;
       break;
     }
   }
   for (uint32_t i = 0; i < pArray->GetCount(); i++)
-    if (pArray->GetElementValue(i)->GetUnicodeText() == opt_value &&
+    if (pArray->GetDirectObjectAt(i)->GetUnicodeText() == opt_value &&
         (int)i == iPos) {
       return TRUE;
     }
   return FALSE;
 }
 FX_BOOL CPDF_FormField::SetItemSelection(int index,
                                          FX_BOOL bSelected,
                                          FX_BOOL bNotify) {
   ASSERT(GetType() == ComboBox || GetType() == ListBox);
   if (index < 0 || index >= CountOptions()) {
@@ skipping 132 matching lines @@
 }
 int CPDF_FormField::CountOptions() {
   CPDF_Array* pArray = ToArray(FPDF_GetFieldAttr(m_pDict, "Opt"));
   return pArray ? pArray->GetCount() : 0;
 }
 CFX_WideString CPDF_FormField::GetOptionText(int index, int sub_index) {
   CPDF_Array* pArray = ToArray(FPDF_GetFieldAttr(m_pDict, "Opt"));
   if (!pArray)
     return CFX_WideString();
 
-  CPDF_Object* pOption = pArray->GetElementValue(index);
+  CPDF_Object* pOption = pArray->GetDirectObjectAt(index);
   if (!pOption)
     return CFX_WideString();
   if (CPDF_Array* pOptionArray = pOption->AsArray())
-    pOption = pOptionArray->GetElementValue(sub_index);
+    pOption = pOptionArray->GetDirectObjectAt(sub_index);
 
   CPDF_String* pString = ToString(pOption);
   return pString ? pString->GetUnicodeText() : CFX_WideString();
 }
 CFX_WideString CPDF_FormField::GetOptionLabel(int index) {
   return GetOptionText(index, 1);
 }
 CFX_WideString CPDF_FormField::GetOptionValue(int index) {
   return GetOptionText(index, 0);
 }
@@ skipping 379 matching lines @@
     pFontDict = m_pForm->m_pFormDict->GetDictBy("DR")
                     ->GetDictBy("Font")
                     ->GetDictBy(font_name);
 
   if (!pFontDict) {
     return;
   }
   m_pFont = m_pForm->m_pDocument->LoadFont(pFontDict);
   m_FontSize = FX_atof(syntax.GetWord());
 }