|
Revert of Introduce GpuVideoDecodeAcceleratorFactory. (patchset #22 id:600001 of https://codereview.chromium.org/1745903002/ )
Reason for revert:
Too many problems: Android, Win64 linking, component linking (duplicate code die to incorrect visibility)
Original issue's description:
> Introduce GpuVideoDecodeAcceleratorFactory.
>
> - Move platform-specific code from GpuVideoDecodeAccelerator to
> GpuVideoDecodeAcceleratorFactory.
>
> - Make GVDAFactory a content/public interface, to provide the ability to
> instantiate VDAs from outside content/.
>
> - Unify how we obtain access to various GL functionality/classes from VDAs
> by introducing a set of callbacks provided by the client.
>
> - Replace VDA::CanDecodeOnIOThread() with
> VDA::TryInitializeDecodeOnSeparateThread(). This allows us to remove
> additional client/taskrunner arguments from VDA constructors, and give client
> the option to use a separate thread to decode, instead of having to make this
> decision in the factory, and enforcing these arguments in the constructors.
>
> - Deduplicate VDA creation code across users (currently GVDA and vdaunittest).
>
> BUG=b/27687678
> TEST=compile/run various VDA impls
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/6977e5243786901a766a38c2c291464875dffbd6
> Cr-Commit-Position: refs/heads/master@{#383256}
TBR=jochen@chromium.org,ananta@chromium.org,fsamuel@chromium.org,kcwu@chromium.org,liberato@chromium.org,owenlin@chromium.org,sandersd@chromium.org,jam@chromium.org,boliu@chromium.org,posciak@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=b/27687678
Committed: https://crrev.com/affa906687c76c929545f8073fffaa53ff3a1a4a
Cr-Commit-Position: refs/heads/master@{#383300}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+596 lines, -1118 lines) |
Patch |
 |
M |
content/common/gpu/media/android_video_decode_accelerator.h
|
View
|
|
5 chunks |
+7 lines, -11 lines |
0 comments
|
Download
|
 |
M |
content/common/gpu/media/android_video_decode_accelerator.cc
|
View
|
|
7 chunks |
+33 lines, -43 lines |
0 comments
|
Download
|
 |
M |
content/common/gpu/media/android_video_decode_accelerator_unittest.cc
|
View
|
|
2 chunks |
+1 line, -7 lines |
0 comments
|
Download
|
 |
M |
content/common/gpu/media/dxva_video_decode_accelerator_win.h
|
View
|
|
5 chunks |
+7 lines, -10 lines |
0 comments
|
Download
|
 |
M |
content/common/gpu/media/dxva_video_decode_accelerator_win.cc
|
View
|
|
9 chunks |
+14 lines, -24 lines |
0 comments
|
Download
|
 |
M |
content/common/gpu/media/fake_video_decode_accelerator.h
|
View
|
|
4 chunks |
+6 lines, -8 lines |
0 comments
|
Download
|
 |
M |
content/common/gpu/media/fake_video_decode_accelerator.cc
|
View
|
|
3 chunks |
+10 lines, -9 lines |
0 comments
|
Download
|
 |
M |
content/common/gpu/media/gpu_video_decode_accelerator.h
|
View
|
|
4 chunks |
+35 lines, -11 lines |
0 comments
|
Download
|
 |
M |
content/common/gpu/media/gpu_video_decode_accelerator.cc
|
View
|
|
6 chunks |
+208 lines, -92 lines |
0 comments
|
Download
|
 |
D |
content/common/gpu/media/gpu_video_decode_accelerator_factory_impl.h
|
View
|
|
1 chunk |
+0 lines, -126 lines |
0 comments
|
Download
|
 |
D |
content/common/gpu/media/gpu_video_decode_accelerator_factory_impl.cc
|
View
|
|
1 chunk |
+0 lines, -241 lines |
0 comments
|
Download
|
 |
D |
content/common/gpu/media/gpu_video_decode_accelerator_helpers.h
|
View
|
|
1 chunk |
+0 lines, -59 lines |
0 comments
|
Download
|
 |
M |
content/common/gpu/media/rendering_helper.h
|
View
|
|
1 chunk |
+4 lines, -1 line |
0 comments
|
Download
|
 |
M |
content/common/gpu/media/rendering_helper.cc
|
View
|
|
1 chunk |
+6 lines, -2 lines |
0 comments
|
Download
|
 |
M |
content/common/gpu/media/v4l2_slice_video_decode_accelerator.h
|
View
|
|
6 chunks |
+13 lines, -16 lines |
0 comments
|
Download
|
 |
M |
content/common/gpu/media/v4l2_slice_video_decode_accelerator.cc
|
View
|
|
14 chunks |
+22 lines, -39 lines |
0 comments
|
Download
|
 |
M |
content/common/gpu/media/v4l2_video_decode_accelerator.h
|
View
|
|
6 chunks |
+14 lines, -17 lines |
0 comments
|
Download
|
 |
M |
content/common/gpu/media/v4l2_video_decode_accelerator.cc
|
View
|
|
14 chunks |
+21 lines, -40 lines |
0 comments
|
Download
|
 |
M |
content/common/gpu/media/vaapi_drm_picture.h
|
View
|
|
3 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
content/common/gpu/media/vaapi_drm_picture.cc
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
content/common/gpu/media/vaapi_picture.h
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
content/common/gpu/media/vaapi_picture.cc
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
content/common/gpu/media/vaapi_tfp_picture.h
|
View
|
|
3 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
content/common/gpu/media/vaapi_tfp_picture.cc
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
content/common/gpu/media/vaapi_video_decode_accelerator.h
|
View
|
|
5 chunks |
+10 lines, -13 lines |
0 comments
|
Download
|
 |
M |
content/common/gpu/media/vaapi_video_decode_accelerator.cc
|
View
|
|
5 chunks |
+9 lines, -18 lines |
0 comments
|
Download
|
 |
M |
content/common/gpu/media/video_decode_accelerator_unittest.cc
|
View
|
|
9 chunks |
+123 lines, -52 lines |
0 comments
|
Download
|
 |
M |
content/common/gpu/media/vt_video_decode_accelerator_mac.h
|
View
|
|
4 chunks |
+5 lines, -10 lines |
0 comments
|
Download
|
 |
M |
content/common/gpu/media/vt_video_decode_accelerator_mac.cc
|
View
|
|
6 chunks |
+9 lines, -19 lines |
0 comments
|
Download
|
 |
M |
content/content_common.gypi
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
content/content_gpu.gypi
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
content/public/gpu/BUILD.gn
|
View
|
|
2 chunks |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
D |
content/public/gpu/DEPS
|
View
|
|
1 chunk |
+0 lines, -9 lines |
0 comments
|
Download
|
 |
D |
content/public/gpu/gpu_video_decode_accelerator_factory.h
|
View
|
|
1 chunk |
+0 lines, -96 lines |
0 comments
|
Download
|
 |
D |
content/public/gpu/gpu_video_decode_accelerator_factory.cc
|
View
|
|
1 chunk |
+0 lines, -68 lines |
0 comments
|
Download
|
 |
M |
gpu/command_buffer/service/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
gpu/config/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
media/video/mock_video_decode_accelerator.h
|
View
|
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
 |
M |
media/video/video_decode_accelerator.h
|
View
|
|
3 chunks |
+15 lines, -39 lines |
0 comments
|
Download
|
 |
M |
media/video/video_decode_accelerator.cc
|
View
|
|
1 chunk |
+3 lines, -5 lines |
0 comments
|
Download
|
Total messages: 5 (1 generated)
|