Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: content/common/gpu/media/android_video_decode_accelerator.h

Issue 1832123002: Revert of Introduce GpuVideoDecodeAcceleratorFactory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/common/gpu/media/android_video_decode_accelerator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/gpu/media/android_video_decode_accelerator.h
diff --git a/content/common/gpu/media/android_video_decode_accelerator.h b/content/common/gpu/media/android_video_decode_accelerator.h
index badb64c39eadbae4582514a81e07cd5200ed618b..9e6645b9dbcd8c19b3d300f7dec98ae967e6ab43 100644
--- a/content/common/gpu/media/android_video_decode_accelerator.h
+++ b/content/common/gpu/media/android_video_decode_accelerator.h
@@ -18,7 +18,6 @@
#include "base/timer/timer.h"
#include "content/common/content_export.h"
#include "content/common/gpu/media/avda_state_provider.h"
-#include "content/common/gpu/media/gpu_video_decode_accelerator_helpers.h"
#include "gpu/command_buffer/service/gles2_cmd_decoder.h"
#include "gpu/command_buffer/service/gpu_preferences.h"
#include "media/base/android/media_drm_bridge_cdm_context.h"
@@ -111,8 +110,8 @@
};
AndroidVideoDecodeAccelerator(
- const MakeGLContextCurrentCallback& make_context_current_cb,
- const GetGLES2DecoderCallback& get_gles2_decoder_cb);
+ const base::WeakPtr<gpu::gles2::GLES2Decoder> decoder,
+ const base::Callback<bool(void)>& make_context_current);
~AndroidVideoDecodeAccelerator() override;
@@ -126,10 +125,7 @@
void Flush() override;
void Reset() override;
void Destroy() override;
- bool TryToSetupDecodeOnSeparateThread(
- const base::WeakPtr<Client>& decode_client,
- const scoped_refptr<base::SingleThreadTaskRunner>& decode_task_runner)
- override;
+ bool CanDecodeOnIOThread() override;
// AVDAStateProvider implementation:
const gfx::Size& GetSize() const override;
@@ -245,10 +241,7 @@
Client* client_;
// Callback to set the correct gl context.
- MakeGLContextCurrentCallback make_context_current_cb_;
-
- // Callback to get the GLES2Decoder instance.
- GetGLES2DecoderCallback get_gles2_decoder_cb_;
+ base::Callback<bool(void)> make_context_current_;
// Codec type. Used when we configure media codec.
media::VideoCodec codec_;
@@ -306,6 +299,9 @@
// NotifyEndOfBitstreamBuffer() before getting output from the bitstream.
std::list<int32_t> bitstreams_notified_in_advance_;
+ // Owner of the GL context. Used to restore the context state.
+ base::WeakPtr<gpu::gles2::GLES2Decoder> gl_decoder_;
+
// Backing strategy that we'll use to connect PictureBuffers to frames.
scoped_ptr<BackingStrategy> strategy_;
« no previous file with comments | « no previous file | content/common/gpu/media/android_video_decode_accelerator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698