Fix a race condition in canvas hibernation when visibility is toggled repeatedly

Fix a race condition in canvas hibernation when visibility is toggled repeatedly

BUG=590100
Committed: https://crrev.com/ec79563bd9b26a360c453c5bee4af6c8cfc38d39
Cr-Commit-Position: refs/heads/master@{#378014}

[Justin Novosad, 2016-02-26 20:07:45]

junov@chromium.org changed reviewers:
+ senorblanco@chromium.org

[Justin Novosad, 2016-02-26 20:07:46]

PTAL

[Stephen White, 2016-02-26 20:16:04]

LGTM

https://codereview.chromium.org/1736333002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
(right):

https://codereview.chromium.org/1736333002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp:212:
m_hibernationScheduled = false;
For the future, it might be worth thinking about turning Canvas2DLayerBridge
into a state machine, and turning (some of) these bools into an enum.

[Justin Novosad, 2016-02-26 20:21:42]

On 2016/02/26 20:16:04, Stephen White wrote:
> LGTM
> 
>
https://codereview.chromium.org/1736333002/diff/1/third_party/WebKit/Source/p...
> File third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
> (right):
> 
>
https://codereview.chromium.org/1736333002/diff/1/third_party/WebKit/Source/p...
> third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp:212:
> m_hibernationScheduled = false;
> For the future, it might be worth thinking about turning Canvas2DLayerBridge
> into a state machine, and turning (some of) these bools into an enum.

Good idea. Things are getting a bit complex here in the boolean logic. I filed a
bug to follow-up: crbug.com/590310

[Justin Novosad, 2016-02-26 20:21:46]

The CQ bit was checked by junov@chromium.org

[commit-bot: I haz the power, 2016-02-26 20:26:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1736333002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1736333002/1

[commit-bot: I haz the power, 2016-02-26 20:42:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-26 20:42:57]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Justin Novosad, 2016-02-26 20:59:51]

The CQ bit was checked by junov@chromium.org

[commit-bot: I haz the power, 2016-02-26 21:00:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1736333002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1736333002/1

[commit-bot: I haz the power, 2016-02-26 21:07:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-26 21:07:28]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Justin Novosad, 2016-02-26 22:06:04]

The CQ bit was checked by junov@chromium.org

[commit-bot: I haz the power, 2016-02-26 22:07:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1736333002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1736333002/1

[commit-bot: I haz the power, 2016-02-26 22:54:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-26 22:56:39]

Description was changed from

==========
Fix a race condition in canvas hibernation when visibility is toggled repeatedly

BUG=590100
==========

to

==========
Fix a race condition in canvas hibernation when visibility is toggled repeatedly

BUG=590100

Committed: https://crrev.com/ec79563bd9b26a360c453c5bee4af6c8cfc38d39
Cr-Commit-Position: refs/heads/master@{#378014}
==========

[commit-bot: I haz the power, 2016-02-26 22:56:40]

Patchset 1 (id:??) landed as
https://crrev.com/ec79563bd9b26a360c453c5bee4af6c8cfc38d39
Cr-Commit-Position: refs/heads/master@{#378014}