Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 1889153003: Remove ImageData::dispose() (Closed)

Created:
4 years, 8 months ago by Justin Novosad
Modified:
4 years, 8 months ago
Reviewers:
haraken, sof
CC:
chromium-reviews, dshwang, oilpan-reviews, Mads Ager (chromium), ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, Justin Novosad, dglazkov+blink, Rik, blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ImageData::dispose() Now that DOMUint8ClampedArray is always a GarbageCollected type, ImageData::dispose() does not actually achieve anything useful. Since The m_data field always becomes unreachable at the same time as its parent ImageBitmapObject, scoped disposal is pointless. Since this was the only use of the ScopedDisposal template, we can remove that too. BUG=603934 Committed: https://crrev.com/df8336d8c14172e886bcb2cfb49828e9ab92e33c Cr-Commit-Position: refs/heads/master@{#389247}

Patch Set 1 #

Total comments: 1

Patch Set 2 : reverted Handle.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/ImageData.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/ImageData.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
Justin Novosad
PTAL
4 years, 8 months ago (2016-04-15 20:49:11 UTC) #2
haraken
LGTM
4 years, 8 months ago (2016-04-16 00:54:29 UTC) #3
sof
https://codereview.chromium.org/1889153003/diff/1/third_party/WebKit/Source/platform/heap/Handle.h File third_party/WebKit/Source/platform/heap/Handle.h (left): https://codereview.chromium.org/1889153003/diff/1/third_party/WebKit/Source/platform/heap/Handle.h#oldcode1043 third_party/WebKit/Source/platform/heap/Handle.h:1043: typename RawPtrOrMemberTrait<T>::Type m_object; This was/is the sole use of ...
4 years, 8 months ago (2016-04-16 05:25:16 UTC) #5
sof
don't want to hold up worthy CLs.. i'm ok with going either way here, will ...
4 years, 8 months ago (2016-04-20 11:42:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889153003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889153003/20001
4 years, 8 months ago (2016-04-22 18:35:17 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-22 21:30:53 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 21:32:15 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/df8336d8c14172e886bcb2cfb49828e9ab92e33c
Cr-Commit-Position: refs/heads/master@{#389247}

Powered by Google App Engine
This is Rietveld 408576698