Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 1762783002: Disable canvas hibernation on MacOSX to fix content loss issue (Closed)

Created:
4 years, 9 months ago by Justin Novosad
Modified:
4 years, 9 months ago
Reviewers:
Stephen White
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, ajuma+watch-canvas_chromium.org, dshwang, jbroman, Justin Novosad, danakj+watch_chromium.org, Rik, f(malita), blink-reviews, vmpstr+blinkwatch_chromium.org, kinuko+watch, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable canvas hibernation on MacOSX to fix content loss issue Tab switching can cause canvases to go blank on Mac. This is a temporary solution until a proper fix can be found. BUG=588434 Committed: https://crrev.com/db1d1c9054628f3c0b2e46029447aa08635b13d0 Cr-Commit-Position: refs/heads/master@{#380245}

Patch Set 1 #

Patch Set 2 : build fix #

Patch Set 3 : Added unit test suppressions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -1 line) Patch
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp View 1 2 13 chunks +52 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
Justin Novosad
PTAL
4 years, 9 months ago (2016-03-03 19:43:27 UTC) #2
Stephen White
LGTM
4 years, 9 months ago (2016-03-03 19:44:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762783002/1
4 years, 9 months ago (2016-03-03 19:47:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/168361) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 9 months ago (2016-03-03 20:04:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762783002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762783002/20001
4 years, 9 months ago (2016-03-04 14:26:49 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/190421)
4 years, 9 months ago (2016-03-04 17:03:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762783002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762783002/40001
4 years, 9 months ago (2016-03-09 21:17:28 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-09 22:37:04 UTC) #16
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 22:48:06 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/db1d1c9054628f3c0b2e46029447aa08635b13d0
Cr-Commit-Position: refs/heads/master@{#380245}

Powered by Google App Engine
This is Rietveld 408576698