Make OffscreenCanvasRenderingContext2D renderable on a worker

Make OffscreenCanvasRenderingContext2D renderable on a worker

This change makes 2D contexts renderable on workers. It only
implements the bare minimum interfaces required to draw rectangles
on a worker and bring the results to screen via ImageBitmap transfer.
The new Web APIs that are implemented are:
* OffscreenCanvasRendering2D.fillStyle
* OffscreenCanvasRendering2D.strokeStyle
* OffscreenCanvasRendering2D.fillRect
* OffscreenCanvasRendering2D.strokeRect
* OffscreenCanvasRendering2D.clearRect
* OffscreenCanvas.transferToImageBitmap

BUG=563856, 563832
Committed: https://crrev.com/3e81032f06d758c0e79fec2158f1b928f3487036
Cr-Commit-Position: refs/heads/master@{#381085}

[Justin Novosad, 2016-03-08 21:41:49]

Description was changed from

==========
Make OffscreenCanvasRendering2D renderable on a worker

This change makes 2D contexts renderable on workers. I only
implements the bare minimum interfaces required to draw rectangles
on a worker and bring the results to screen via ImageBitmap transfer.
The new WebAPI that are implemented are:
* OffscreenCanvasRendering2D.fillStyle
* OffscreenCanvasRendering2D.strokeStyle
* OffscreenCanvasRendering2D.fillRect
* OffscreenCanvasRendering2D.strokeRect
* OffscreenCanvasRendering2D.clearRect
* OffscreenCanvas.transferToImageBitmap

BUG=563856, 563832
==========

to

==========
Make OffscreenCanvasRendering2D renderable on a worker

This change makes 2D contexts renderable on workers. I only
implements the bare minimum interfaces required to draw rectangles
on a worker and bring the results to screen via ImageBitmap transfer.
The new Web APIs that are implemented are:
* OffscreenCanvasRendering2D.fillStyle
* OffscreenCanvasRendering2D.strokeStyle
* OffscreenCanvasRendering2D.fillRect
* OffscreenCanvasRendering2D.strokeRect
* OffscreenCanvasRendering2D.clearRect
* OffscreenCanvas.transferToImageBitmap

BUG=563856, 563832
==========

[Justin Novosad, 2016-03-08 21:43:20]

junov@chromium.org changed reviewers:
+ senorblanco@chromium.org, xidachen@chromium.org, xlai@chromium.org

[Justin Novosad, 2016-03-08 21:43:21]

PTAL.  We are producing pixels in a worker, and bringing them to display. Yay!

[Justin Novosad, 2016-03-08 21:49:06]

Description was changed from

==========
Make OffscreenCanvasRendering2D renderable on a worker

This change makes 2D contexts renderable on workers. I only
implements the bare minimum interfaces required to draw rectangles
on a worker and bring the results to screen via ImageBitmap transfer.
The new Web APIs that are implemented are:
* OffscreenCanvasRendering2D.fillStyle
* OffscreenCanvasRendering2D.strokeStyle
* OffscreenCanvasRendering2D.fillRect
* OffscreenCanvasRendering2D.strokeRect
* OffscreenCanvasRendering2D.clearRect
* OffscreenCanvas.transferToImageBitmap

BUG=563856, 563832
==========

to

==========
Make OffscreenCanvasRenderingContext2D renderable on a worker

This change makes 2D contexts renderable on workers. I only
implements the bare minimum interfaces required to draw rectangles
on a worker and bring the results to screen via ImageBitmap transfer.
The new Web APIs that are implemented are:
* OffscreenCanvasRendering2D.fillStyle
* OffscreenCanvasRendering2D.strokeStyle
* OffscreenCanvasRendering2D.fillRect
* OffscreenCanvasRendering2D.strokeRect
* OffscreenCanvasRendering2D.clearRect
* OffscreenCanvas.transferToImageBitmap

BUG=563856, 563832
==========

[Stephen White, 2016-03-08 22:46:33]

https://codereview.chromium.org/1775153002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h
(right):

https://codereview.chromium.org/1775153002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h:159: virtual
void updateFilterReferences(const FilterOperations& filters) { }
Could these filter-related changes be made in another patch?

[Justin Novosad, 2016-03-08 22:49:55]

On 2016/03/08 22:46:33, Stephen White wrote:
>
https://codereview.chromium.org/1775153002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h
> (right):
> 
>
https://codereview.chromium.org/1775153002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h:159:
virtual
> void updateFilterReferences(const FilterOperations& filters) { }
> Could these filter-related changes be made in another patch?

They could. I just need getFilter/hasFilter to be callable, they don't actually
need to work until we expose the filter attribute.

[Justin Novosad, 2016-03-09 18:32:07]

new patch

[Justin Novosad, 2016-03-09 18:32:57]

Description was changed from

==========
Make OffscreenCanvasRenderingContext2D renderable on a worker

This change makes 2D contexts renderable on workers. I only
implements the bare minimum interfaces required to draw rectangles
on a worker and bring the results to screen via ImageBitmap transfer.
The new Web APIs that are implemented are:
* OffscreenCanvasRendering2D.fillStyle
* OffscreenCanvasRendering2D.strokeStyle
* OffscreenCanvasRendering2D.fillRect
* OffscreenCanvasRendering2D.strokeRect
* OffscreenCanvasRendering2D.clearRect
* OffscreenCanvas.transferToImageBitmap

BUG=563856, 563832
==========

to

==========
Make OffscreenCanvasRenderingContext2D renderable on a worker

This change makes 2D contexts renderable on workers. It only
implements the bare minimum interfaces required to draw rectangles
on a worker and bring the results to screen via ImageBitmap transfer.
The new Web APIs that are implemented are:
* OffscreenCanvasRendering2D.fillStyle
* OffscreenCanvasRendering2D.strokeStyle
* OffscreenCanvasRendering2D.fillRect
* OffscreenCanvasRendering2D.strokeRect
* OffscreenCanvasRendering2D.clearRect
* OffscreenCanvas.transferToImageBitmap

BUG=563856, 563832
==========

[Stephen White, 2016-03-09 18:54:07]

Awesome! \o/

Just a few nits.

https://codereview.chromium.org/1775153002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-clearRect-in-worker.html
(right):

https://codereview.chromium.org/1775153002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-clearRect-in-worker.html:6:
<script id="myWorker" type="text/worker">
uNit: use ' or " for attribute values, not both (Emerson's hobgoblin)

https://codereview.chromium.org/1775153002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-fillRect-in-worker.html
(right):

https://codereview.chromium.org/1775153002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-fillRect-in-worker.html:6:
<script id="myWorker" type="text/worker">
uNit: use ' or " for attribute values, not both

https://codereview.chromium.org/1775153002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-strokeRect-in-worker.html
(right):

https://codereview.chromium.org/1775153002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-strokeRect-in-worker.html:6:
<script id="myWorker" type="text/worker">
uNit: use ' or " for attribute values, not both (Emerson's hobgoblin)

https://codereview.chromium.org/1775153002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp
(right):

https://codereview.chromium.org/1775153002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp:81:
RefPtr<SkImage> skImage =
m_imageBuffer->newSkImageSnapshot(PreferNoAcceleration, SnapshotReasonUnknown);
Add a reference to a bug for making OffscreenCanvas GPU-friendly?

https://codereview.chromium.org/1775153002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp:122:
// TODO: make hasFilter accept nullptr
Add a bug reference here?

[Stephen White, 2016-03-10 18:52:01]

LGTM

[Justin Novosad, 2016-03-10 18:52:09]

The CQ bit was checked by junov@chromium.org

[commit-bot: I haz the power, 2016-03-10 18:52:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1775153002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1775153002/80001

[commit-bot: I haz the power, 2016-03-10 18:56:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 18:56:33]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Justin Novosad, 2016-03-14 20:38:57]

The CQ bit was checked by junov@chromium.org

[Justin Novosad, 2016-03-14 20:38:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
senorblanco@chromium.org
Link to the patchset: https://codereview.chromium.org/1775153002/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2016-03-14 20:39:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1775153002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1775153002/100001

[commit-bot: I haz the power, 2016-03-14 22:10:27]

Description was changed from

==========
Make OffscreenCanvasRenderingContext2D renderable on a worker

This change makes 2D contexts renderable on workers. It only
implements the bare minimum interfaces required to draw rectangles
on a worker and bring the results to screen via ImageBitmap transfer.
The new Web APIs that are implemented are:
* OffscreenCanvasRendering2D.fillStyle
* OffscreenCanvasRendering2D.strokeStyle
* OffscreenCanvasRendering2D.fillRect
* OffscreenCanvasRendering2D.strokeRect
* OffscreenCanvasRendering2D.clearRect
* OffscreenCanvas.transferToImageBitmap

BUG=563856, 563832
==========

to

==========
Make OffscreenCanvasRenderingContext2D renderable on a worker

This change makes 2D contexts renderable on workers. It only
implements the bare minimum interfaces required to draw rectangles
on a worker and bring the results to screen via ImageBitmap transfer.
The new Web APIs that are implemented are:
* OffscreenCanvasRendering2D.fillStyle
* OffscreenCanvasRendering2D.strokeStyle
* OffscreenCanvasRendering2D.fillRect
* OffscreenCanvasRendering2D.strokeRect
* OffscreenCanvasRendering2D.clearRect
* OffscreenCanvas.transferToImageBitmap

BUG=563856, 563832
==========

[commit-bot: I haz the power, 2016-03-14 22:10:28]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-03-14 22:11:30]

Description was changed from

==========
Make OffscreenCanvasRenderingContext2D renderable on a worker

This change makes 2D contexts renderable on workers. It only
implements the bare minimum interfaces required to draw rectangles
on a worker and bring the results to screen via ImageBitmap transfer.
The new Web APIs that are implemented are:
* OffscreenCanvasRendering2D.fillStyle
* OffscreenCanvasRendering2D.strokeStyle
* OffscreenCanvasRendering2D.fillRect
* OffscreenCanvasRendering2D.strokeRect
* OffscreenCanvasRendering2D.clearRect
* OffscreenCanvas.transferToImageBitmap

BUG=563856, 563832
==========

to

==========
Make OffscreenCanvasRenderingContext2D renderable on a worker

This change makes 2D contexts renderable on workers. It only
implements the bare minimum interfaces required to draw rectangles
on a worker and bring the results to screen via ImageBitmap transfer.
The new Web APIs that are implemented are:
* OffscreenCanvasRendering2D.fillStyle
* OffscreenCanvasRendering2D.strokeStyle
* OffscreenCanvasRendering2D.fillRect
* OffscreenCanvasRendering2D.strokeRect
* OffscreenCanvasRendering2D.clearRect
* OffscreenCanvas.transferToImageBitmap

BUG=563856, 563832

Committed: https://crrev.com/3e81032f06d758c0e79fec2158f1b928f3487036
Cr-Commit-Position: refs/heads/master@{#381085}
==========

[commit-bot: I haz the power, 2016-03-14 22:11:31]

Patchset 6 (id:??) landed as
https://crrev.com/3e81032f06d758c0e79fec2158f1b928f3487036
Cr-Commit-Position: refs/heads/master@{#381085}