Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 1775613002: Throw a RangeError exception from get/createImageData when out of memory (Closed)

Created:
4 years, 9 months ago by Justin Novosad
Modified:
4 years, 9 months ago
Reviewers:
Stephen White
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, ajuma+watch-canvas_chromium.org, dshwang, jbroman, Justin Novosad, danakj+watch_chromium.org, Rik, f(malita), blink-reviews, vmpstr+blinkwatch_chromium.org, kinuko+watch, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Throw a RangeError exception from get/createImageData when out of memory This change is to comply with this recent change to the spec: https://github.com/whatwg/html/commit/ca522a7478bc0db74a1f96f95ae499087b3655ec BUG=535136, 536816, 532337 Committed: https://crrev.com/93c3b0f255223a2805834cb1d6f0a4bd6bba01c0 Cr-Commit-Position: refs/heads/master@{#379837}

Patch Set 1 #

Total comments: 1

Patch Set 2 : readability fix #

Patch Set 3 : fix assert in test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -16 lines) Patch
M third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp View 3 chunks +18 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DAPITest.cpp View 1 2 2 chunks +22 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp View 1 2 chunks +13 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (8 generated)
Justin Novosad
PTAL
4 years, 9 months ago (2016-03-07 21:48:40 UTC) #2
Stephen White
LGTM https://codereview.chromium.org/1775613002/diff/1/third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp File third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp (right): https://codereview.chromium.org/1775613002/diff/1/third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp#newcode318 third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp:318: WTF::ArrayBufferContents::allocateMemoryOrNull(allocSizeInBytes, mayHaveStrayArea ? WTF::ArrayBufferContents::ZeroInitialize : WTF::ArrayBufferContents::DontInitialize, data); Nit: ...
4 years, 9 months ago (2016-03-07 22:09:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775613002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775613002/40001
4 years, 9 months ago (2016-03-07 22:39:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/32298) android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, ...
4 years, 9 months ago (2016-03-07 22:43:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775613002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775613002/40001
4 years, 9 months ago (2016-03-07 22:47:22 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/126521) chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 9 months ago (2016-03-07 22:48:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775613002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775613002/40001
4 years, 9 months ago (2016-03-08 14:41:46 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-08 16:10:35 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 16:12:59 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/93c3b0f255223a2805834cb1d6f0a4bd6bba01c0
Cr-Commit-Position: refs/heads/master@{#379837}

Powered by Google App Engine
This is Rietveld 408576698