Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 1874373003: Replace ASSERTs with exit condition in StaticBitmapImage::draw (Closed)

Created:
4 years, 8 months ago by Justin Novosad
Modified:
4 years, 8 months ago
Reviewers:
Stephen White
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, Stephen Chennney, blink-reviews, f(malita), danakj+watch_chromium.org, kinuko+watch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ASSERTs with exit condition in StaticBitmapImage::draw In degenerate cases (like the layout test added by this change), the layout box may end up with a negative dimension due to an overflow in the layout arithmetic. Is such cases, we should just fail gracefully by rejecting the draw operation. BUG=544329 Committed: https://crrev.com/35f1d95ad849975161a609311a265974ac93c71b Cr-Commit-Position: refs/heads/master@{#386704}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/fast/canvas/bug544329.html View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/canvas/bug544329-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/StaticBitmapImage.cpp View 1 chunk +7 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
Justin Novosad
4 years, 8 months ago (2016-04-11 18:42:55 UTC) #2
Stephen White
LGTM
4 years, 8 months ago (2016-04-11 18:54:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1874373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1874373003/1
4 years, 8 months ago (2016-04-11 18:58:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/209114)
4 years, 8 months ago (2016-04-11 22:19:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1874373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1874373003/1
4 years, 8 months ago (2016-04-12 15:33:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 16:13:19 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 16:14:56 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/35f1d95ad849975161a609311a265974ac93c71b
Cr-Commit-Position: refs/heads/master@{#386704}

Powered by Google App Engine
This is Rietveld 408576698