Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1179)

Issue 1934363002: Improve robustness of lost context checks in Canvas2DLayerBridge (Closed)

Created:
4 years, 7 months ago by Justin Novosad
Modified:
4 years, 7 months ago
Reviewers:
Stephen White
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, ajuma+watch-canvas_chromium.org, dshwang, jbroman, Justin Novosad, danakj+watch_chromium.org, Rik, f(malita), blink-reviews, kinuko+watch, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve robustness of lost context checks in Canvas2DLayerBridge To avoid crashes caused by unexpected inconsistent states when a GPU context loss occurs, we make Canvas2DLayerBridge::contextGL return null when the checkSurfaceValid fails in order to allow calling code to abort cleanly by performing null checks on the return of contextGL. BUG=598712 Committed: https://crrev.com/5d0d1d13c683a3a8b9a200332e9d479d5d14d4f1 Cr-Commit-Position: refs/heads/master@{#391096}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp View 5 chunks +13 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (7 generated)
Justin Novosad
PTAL
4 years, 7 months ago (2016-05-02 15:20:00 UTC) #2
Stephen White
LGTM
4 years, 7 months ago (2016-05-02 17:28:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1934363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1934363002/1
4 years, 7 months ago (2016-05-02 17:52:21 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/214925)
4 years, 7 months ago (2016-05-02 21:33:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1934363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1934363002/1
4 years, 7 months ago (2016-05-02 22:15:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 23:35:55 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 23:38:38 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d0d1d13c683a3a8b9a200332e9d479d5d14d4f1
Cr-Commit-Position: refs/heads/master@{#391096}

Powered by Google App Engine
This is Rietveld 408576698