Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1913213003: Raname ImageBitmapRenderingContext's transferImageBitmap to transferFromImageBitmap (Closed)

Created:
4 years, 8 months ago by Justin Novosad
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Raname ImageBitmapRenderingContext's transferImageBitmap to transferFromImageBitmap BUG=606031 TBR=xlai@chromium.org, xidachen@chromium.org Committed: https://crrev.com/f42dfa82c14388c3dcd799b2a59e55b72f6336e0 Cr-Commit-Position: refs/heads/master@{#389510}

Patch Set 1 #

Patch Set 2 : reset test results #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -98 lines) Patch
M third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-clearRect-in-worker.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-fillRect-in-worker.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-paths-in-worker.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-strokeRect-in-worker.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-transform-shadow-in-worker.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/fast/canvas/imagebitmap/transferFromImageBitmap.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/fast/canvas/imagebitmap/transferFromImageBitmap-alpha.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/fast/canvas/imagebitmap/transferFromImageBitmap-alpha-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/canvas/imagebitmap/transferFromImageBitmap-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/canvas/imagebitmap/transferFromImageBitmap-no-alpha.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/fast/canvas/imagebitmap/transferFromImageBitmap-no-alpha-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/imagebitmap/transferImageBitmap.html View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/imagebitmap/transferImageBitmap-alpha.html View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/imagebitmap/transferImageBitmap-alpha-expected.html View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/imagebitmap/transferImageBitmap-expected.html View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/imagebitmap/transferImageBitmap-no-alpha.html View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/imagebitmap/transferImageBitmap-no-alpha-expected.html View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.idl View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1736333002 Patch 1

Messages

Total messages: 16 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913213003/1
4 years, 8 months ago (2016-04-22 21:04:07 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/210151)
4 years, 8 months ago (2016-04-22 22:34:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913213003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913213003/20001
4 years, 8 months ago (2016-04-25 15:56:27 UTC) #7
commit-bot: I haz the power
Failed to commit the patch.
4 years, 8 months ago (2016-04-25 17:45:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913213003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913213003/20001
4 years, 8 months ago (2016-04-25 18:14:08 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-25 18:19:29 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 18:22:00 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f42dfa82c14388c3dcd799b2a59e55b72f6336e0
Cr-Commit-Position: refs/heads/master@{#389510}

Powered by Google App Engine
This is Rietveld 408576698