Remove HostDesktopType from FindLastActive[WithProfile]

Remove HostDesktopType from FindLastActive[WithProfile]

From chrome/browser/ui/browser_finder.h.

R=sky@chromium.org
BUG=558054
Committed: https://crrev.com/5c03fe02699201911d37510b73597e40dba19286
Cr-Commit-Position: refs/heads/master@{#373118}

[scottmg, 2016-02-02 21:50:31]

Description was changed from

==========
Remove HostDesktopType from FindLastActive[WithProfile]

R=sky@chromium.org
BUG=558054
==========

to

==========
Remove HostDesktopType from FindLastActive[WithProfile]

From chrome/browser/ui/browser_finder.h.

R=sky@chromium.org
BUG=558054
==========

[sky, 2016-02-02 22:33:10]

LGTM

https://codereview.chromium.org/1659203002/diff/20001/chrome/browser/download...
File chrome/browser/download/download_ui_controller.cc (right):

https://codereview.chromium.org/1659203002/diff/20001/chrome/browser/download...
chrome/browser/download/download_ui_controller.cc:90: if (browser == NULL)
nit: nullptr

https://codereview.chromium.org/1659203002/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/last_active_browser_cocoa.cc (right):

https://codereview.chromium.org/1659203002/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/last_active_browser_cocoa.cc:11: Browser*
GetLastActiveBrowser() {
Can you nuke this function and replace with FindLastActive?

[scottmg, 2016-02-02 23:08:43]

https://codereview.chromium.org/1659203002/diff/20001/chrome/browser/download...
File chrome/browser/download/download_ui_controller.cc (right):

https://codereview.chromium.org/1659203002/diff/20001/chrome/browser/download...
chrome/browser/download/download_ui_controller.cc:90: if (browser == NULL)
On 2016/02/02 22:33:10, sky wrote:
> nit: nullptr

Done.

https://codereview.chromium.org/1659203002/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/last_active_browser_cocoa.cc (right):

https://codereview.chromium.org/1659203002/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/last_active_browser_cocoa.cc:11: Browser*
GetLastActiveBrowser() {
On 2016/02/02 22:33:10, sky wrote:
> Can you nuke this function and replace with FindLastActive?

The header says it's needed to interface with Obj-C because it can't be friended
otherwise. I can try to remove it on a Mac in a followup if you want though.
Maybe the comment is out of date now?

[sky, 2016-02-02 23:09:03]

Later SGTM

On Tue, Feb 2, 2016 at 3:08 PM,  <scottmg@chromium.org> wrote:
>
>
>
https://codereview.chromium.org/1659203002/diff/20001/chrome/browser/download...
> File chrome/browser/download/download_ui_controller.cc (right):
>
>
https://codereview.chromium.org/1659203002/diff/20001/chrome/browser/download...
> chrome/browser/download/download_ui_controller.cc:90: if (browser ==
> NULL)
> On 2016/02/02 22:33:10, sky wrote:
>> nit: nullptr
>
> Done.
>
>
https://codereview.chromium.org/1659203002/diff/20001/chrome/browser/ui/cocoa...
> File chrome/browser/ui/cocoa/last_active_browser_cocoa.cc (right):
>
>
https://codereview.chromium.org/1659203002/diff/20001/chrome/browser/ui/cocoa...
> chrome/browser/ui/cocoa/last_active_browser_cocoa.cc:11: Browser*
> GetLastActiveBrowser() {
> On 2016/02/02 22:33:10, sky wrote:
>> Can you nuke this function and replace with FindLastActive?
>
> The header says it's needed to interface with Obj-C because it can't be
> friended otherwise. I can try to remove it on a Mac in a followup if you
> want though. Maybe the comment is out of date now?
>
> https://codereview.chromium.org/1659203002/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[scottmg, 2016-02-02 23:09:42]

The CQ bit was checked by scottmg@chromium.org

[scottmg, 2016-02-02 23:09:43]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1659203002/#ps40001
(title: "nullptr")

[commit-bot: I haz the power, 2016-02-02 23:15:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1659203002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1659203002/40001

[commit-bot: I haz the power, 2016-02-03 01:27:31]

Description was changed from

==========
Remove HostDesktopType from FindLastActive[WithProfile]

From chrome/browser/ui/browser_finder.h.

R=sky@chromium.org
BUG=558054
==========

to

==========
Remove HostDesktopType from FindLastActive[WithProfile]

From chrome/browser/ui/browser_finder.h.

R=sky@chromium.org
BUG=558054
==========

[commit-bot: I haz the power, 2016-02-03 01:27:32]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-03 01:28:26]

Description was changed from

==========
Remove HostDesktopType from FindLastActive[WithProfile]

From chrome/browser/ui/browser_finder.h.

R=sky@chromium.org
BUG=558054
==========

to

==========
Remove HostDesktopType from FindLastActive[WithProfile]

From chrome/browser/ui/browser_finder.h.

R=sky@chromium.org
BUG=558054

Committed: https://crrev.com/5c03fe02699201911d37510b73597e40dba19286
Cr-Commit-Position: refs/heads/master@{#373118}
==========

[commit-bot: I haz the power, 2016-02-03 01:28:27]

Patchset 3 (id:??) landed as
https://crrev.com/5c03fe02699201911d37510b73597e40dba19286
Cr-Commit-Position: refs/heads/master@{#373118}