Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1661713002: Remove the rest of HostDesktopType from c/b/ui/browser_finder.h (Closed)

Created:
4 years, 10 months ago by scottmg
Modified:
4 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, zea+watch_chromium.org, bondd+autofillwatch_chromium.org, rginda+watch_chromium.org, noyau+watch_chromium.org, miu+watch_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, Matt Giuca, grt+watch_chromium.org, dzhioev+watch_chromium.org, achuith+watch_chromium.org, vabr+watchlistautofill_chromium.org, kalyank, tapted, rouslan+autofill_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, tfarina, maxbogue+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, plaree+watch_chromium.org, estade+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@metro-mode-11
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the rest of HostDesktopType from c/b/ui/browser_finder.h R=sky@chromium.org BUG=558054 Committed: https://crrev.com/34c5dd881776977d63e49c4b394731c62482183d Cr-Commit-Position: refs/heads/master@{#373182}

Patch Set 1 #

Patch Set 2 : fixes #

Patch Set 3 : rebase #

Patch Set 4 : fix pull, maybe #

Patch Set 5 : linux adl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -344 lines) Patch
M chrome/browser/app_controller_mac.mm View 1 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/captive_portal/captive_portal_browsertest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/chrome_main_browsertest.cc View 1 6 chunks +7 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/login/session_login_browsertest.cc View 1 2 3 4 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/options/network_config_view.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/api/management/chrome_management_api_delegate.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/management/management_apitest.cc View 1 6 chunks +7 lines, -14 lines 0 comments Download
M chrome/browser/extensions/api/sessions/sessions_api.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/app_process_apitest.cc View 1 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/extensions/chrome_extension_function.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/chrome_extension_function_details.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/extensions/chrome_process_manager_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_tab_util.cc View 1 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/extensions/external_install_error.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/extensions/theme_installed_infobar_delegate.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/window_open_apitest.cc View 1 3 chunks +3 lines, -8 lines 0 comments Download
M chrome/browser/platform_util_chromeos.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/profiles/profile_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_metrics.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_window.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_window_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/safe_browsing/srt_fetcher_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/chrome_signin_status_metrics_provider_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/profile_sync_service_harness.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_controller_browsertest.cc View 1 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_view_delegate.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc View 3 chunks +6 lines, -11 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc View 1 5 chunks +6 lines, -14 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 9 chunks +10 lines, -22 lines 0 comments Download
M chrome/browser/ui/browser_command_controller_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/browser_finder.h View 5 chunks +15 lines, -29 lines 0 comments Download
M chrome/browser/ui/browser_finder.cc View 4 chunks +9 lines, -27 lines 0 comments Download
M chrome/browser/ui/browser_finder_chromeos_unittest.cc View 1 3 chunks +12 lines, -24 lines 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/chrome_pages.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm View 2 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/extensions/application_launch.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/extensions/hosted_app_browsertest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/panels/panel_browsertest.cc View 1 4 chunks +4 lines, -12 lines 0 comments Download
M chrome/browser/ui/scoped_tabbed_browser_displayer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.cc View 5 chunks +6 lines, -10 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_browsertest.cc View 1 15 chunks +15 lines, -27 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_interactive_uitest.cc View 1 1 chunk +8 lines, -16 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_triggered_reset_browsertest_win.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/autofill/new_credit_card_bubble_views.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_contents_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/signin/user_manager_screen_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/in_process_browser_test_mac.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
scottmg
4 years, 10 months ago (2016-02-03 00:19:36 UTC) #1
sky
LGTM
4 years, 10 months ago (2016-02-03 00:41:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1661713002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1661713002/60001
4 years, 10 months ago (2016-02-03 01:29:05 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/151390) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 10 months ago (2016-02-03 01:49:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1661713002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1661713002/80001
4 years, 10 months ago (2016-02-03 04:19:42 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 10 months ago (2016-02-03 05:22:04 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 05:23:04 UTC) #12
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/34c5dd881776977d63e49c4b394731c62482183d
Cr-Commit-Position: refs/heads/master@{#373182}

Powered by Google App Engine
This is Rietveld 408576698