chrome/browser/translate/chrome_translate_client.cc - Issue 1659203002: Remove HostDesktopType from FindLastActive[WithProfile]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/translate/chrome_translate_client.cc

Issue 1659203002: Remove HostDesktopType from FindLastActive[WithProfile] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nullptr Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/srt_global_error_win.cc ('k') | chrome/browser/ui/ash/system_tray_delegate_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/translate/chrome_translate_client.cc

diff --git a/chrome/browser/translate/chrome_translate_client.cc b/chrome/browser/translate/chrome_translate_client.cc

index 5cbebe21353609efe2e820ef5dbbed18bc090ad5..76496a4a508ebc0e59fd54164805f3e7524bb840 100644

--- a/chrome/browser/translate/chrome_translate_client.cc

+++ b/chrome/browser/translate/chrome_translate_client.cc

@@ -331,10 +331,8 @@ void ChromeTranslateClient::ShowBubble(

// because the bubble takes the focus from the other widgets including the

// browser windows. So it is checked that |browser| is the last activated

// browser, not is now activated.

- if (browser !=

- chrome::FindLastActiveWithHostDesktopType(browser->host_desktop_type())) {

+ if (browser != chrome::FindLastActive())

return;

- }

// During auto-translating, the bubble should not be shown.

if (step == translate::TRANSLATE_STEP_TRANSLATING ||

« no previous file with comments | « chrome/browser/safe_browsing/srt_global_error_win.cc ('k') | chrome/browser/ui/ash/system_tray_delegate_chromeos.cc » ('j') | no next file with comments »