chrome/browser/download/download_ui_controller.cc - Issue 1659203002: Remove HostDesktopType from FindLastActive[WithProfile]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_ui_controller.cc

Issue 1659203002: Remove HostDesktopType from FindLastActive[WithProfile] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nullptr Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_crx_util.cc ('k') | chrome/browser/extensions/api/extension_action/extension_action_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_ui_controller.cc

diff --git a/chrome/browser/download/download_ui_controller.cc b/chrome/browser/download/download_ui_controller.cc

index 5b45568db437f388da4e5e7522aeaa11f197b6bb..e0bb05bf48dfffa2fd1a5d3262e4e7e30c74580c 100644

--- a/chrome/browser/download/download_ui_controller.cc

+++ b/chrome/browser/download/download_ui_controller.cc

@@ -87,10 +87,8 @@ void DownloadShelfUIControllerDelegate::OnNewDownloadReady(

// As a last resort, use the last active browser for this profile. Not ideal,

// but better than not showing the download at all.

- if (browser == NULL) {

- browser = chrome::FindLastActiveWithProfile(profile_,

- chrome::GetActiveDesktop());

- }

+ if (browser == nullptr)

+ browser = chrome::FindLastActiveWithProfile(profile_);

if (browser && browser->window() &&

DownloadItemModel(item).ShouldShowInShelf()) {