chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc - Issue 1659203002: Remove HostDesktopType from FindLastActive[WithProfile]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc

Issue 1659203002: Remove HostDesktopType from FindLastActive[WithProfile] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nullptr Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/extension_action/extension_action_api.cc ('k') | chrome/browser/extensions/bundle_installer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc

diff --git a/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc b/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc

index 0bab64671cca7f556ae87c4d6540269a354bae79..08231f639315babfed66f03e482d2ddc50494d33 100644

--- a/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc

+++ b/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc

@@ -169,8 +169,7 @@ bool ChromeRuntimeAPIDelegate::CheckForUpdates(

void ChromeRuntimeAPIDelegate::OpenURL(const GURL& uninstall_url) {

Profile* profile = Profile::FromBrowserContext(browser_context_);

- Browser* browser =

- chrome::FindLastActiveWithProfile(profile, chrome::GetActiveDesktop());

+ Browser* browser = chrome::FindLastActiveWithProfile(profile);

if (!browser)

browser =

new Browser(Browser::CreateParams(profile, chrome::GetActiveDesktop()));

@@ -241,8 +240,7 @@ bool ChromeRuntimeAPIDelegate::RestartDevice(std::string* error_message) {

bool ChromeRuntimeAPIDelegate::OpenOptionsPage(const Extension* extension) {

Profile* profile = Profile::FromBrowserContext(browser_context_);

- Browser* browser =

- chrome::FindLastActiveWithProfile(profile, chrome::GetActiveDesktop());

+ Browser* browser = chrome::FindLastActiveWithProfile(profile);

if (!browser)

return false;

return extensions::ExtensionTabUtil::OpenOptionsPage(extension, browser);