chrome/browser/ui/views/select_file_dialog_extension.cc - Issue 1659203002: Remove HostDesktopType from FindLastActive[WithProfile]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/select_file_dialog_extension.cc

Issue 1659203002: Remove HostDesktopType from FindLastActive[WithProfile] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nullptr Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/profiles/user_manager_view.cc ('k') | chrome/browser/ui/webui/signin/inline_login_handler_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/select_file_dialog_extension.cc

diff --git a/chrome/browser/ui/views/select_file_dialog_extension.cc b/chrome/browser/ui/views/select_file_dialog_extension.cc

index 61c50f0c8c8ae3caeaf948678f6b792c9c8f2d7c..9784d6ac7e936e4064c75632f7043a7e93b10038 100644

--- a/chrome/browser/ui/views/select_file_dialog_extension.cc

+++ b/chrome/browser/ui/views/select_file_dialog_extension.cc

@@ -123,10 +123,8 @@ void FindRuntimeContext(gfx::NativeWindow owner_window,

} else {

// If the owning window is still unknown, this could be a background page or

// and extension popup. Use the last active browser.

- if (!owner_browser) {

- owner_browser =

- chrome::FindLastActiveWithHostDesktopType(chrome::GetActiveDesktop());

- }

+ if (!owner_browser)

+ owner_browser = chrome::FindLastActive();

if (owner_browser) {

*base_window = owner_browser->window();

*web_contents = owner_browser->tab_strip_model()->GetActiveWebContents();