chrome/browser/ui/cocoa/last_active_browser_cocoa.cc - Issue 1659203002: Remove HostDesktopType from FindLastActive[WithProfile]

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/last_active_browser_cocoa.cc

Issue 1659203002: Remove HostDesktopType from FindLastActive[WithProfile] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mac adl Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/download/download_ui_controller.cc ('K') | « chrome/browser/ui/cocoa/handoff_active_url_observer.cc ('k') | chrome/browser/ui/content_settings/content_setting_bubble_model_browsertest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/cocoa/last_active_browser_cocoa.h"	5 #include "chrome/browser/ui/cocoa/last_active_browser_cocoa.h"

6	6

7 #include "chrome/browser/ui/browser_finder.h"	7 #include "chrome/browser/ui/browser_finder.h"

8	8

9 namespace chrome {	9 namespace chrome {

10	10

11 Browser* GetLastActiveBrowser() {	11 Browser* GetLastActiveBrowser() {
	sky 2016/02/02 22:33:10 Can you nuke this function and replace with FindLa Can you nuke this function and replace with FindLastActive? scottmg 2016/02/02 23:08:43 The header says it's needed to interface with Obj- Show quoted text On 2016/02/02 22:33:10, sky wrote: > Can you nuke this function and replace with FindLastActive? The header says it's needed to interface with Obj-C because it can't be friended otherwise. I can try to remove it on a Mac in a followup if you want though. Maybe the comment is out of date now?
12 return FindLastActiveWithHostDesktopType(HOST_DESKTOP_TYPE_NATIVE);	12 return FindLastActive();

13 }	13 }

14	14

15 } // namespace chrome	15 } // namespace chrome

OLD	NEW