chrome/browser/ui/content_settings/content_setting_bubble_model_browsertest.cc - Issue 1659203002: Remove HostDesktopType from FindLastActive[WithProfile]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/content_settings/content_setting_bubble_model_browsertest.cc

Issue 1659203002: Remove HostDesktopType from FindLastActive[WithProfile] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nullptr Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/last_active_browser_cocoa.cc ('k') | chrome/browser/ui/extensions/extension_install_ui_default.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/content_settings/content_setting_bubble_model_browsertest.cc

diff --git a/chrome/browser/ui/content_settings/content_setting_bubble_model_browsertest.cc b/chrome/browser/ui/content_settings/content_setting_bubble_model_browsertest.cc

index 6303502533d8e75c07536af037c5498ddf009f8d..2a54f7fe14536627973fc33f32dbc6a56b993ab1 100644

--- a/chrome/browser/ui/content_settings/content_setting_bubble_model_browsertest.cc

+++ b/chrome/browser/ui/content_settings/content_setting_bubble_model_browsertest.cc

@@ -119,8 +119,7 @@ class ContentSettingBubbleModelMediaStreamTest : public InProcessBrowserTest {

content::WebContents* GetActiveTab() {

// First, we need to find the active browser window. It should be at

// the same desktop as the browser in which we invoked the bubble.

- Browser* active_browser = chrome::FindLastActiveWithHostDesktopType(

- browser()->host_desktop_type());

+ Browser* active_browser = chrome::FindLastActive();

return active_browser->tab_strip_model()->GetActiveWebContents();

}

};