chrome/browser/ui/extensions/extension_install_ui_default.cc - Issue 1659203002: Remove HostDesktopType from FindLastActive[WithProfile]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/extension_install_ui_default.cc

Issue 1659203002: Remove HostDesktopType from FindLastActive[WithProfile] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nullptr Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/content_settings/content_setting_bubble_model_browsertest.cc ('k') | chrome/browser/ui/network_profile_bubble.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/extensions/extension_install_ui_default.cc

diff --git a/chrome/browser/ui/extensions/extension_install_ui_default.cc b/chrome/browser/ui/extensions/extension_install_ui_default.cc

index b954ca40268b5b4dcb43b75a774fe0e24beef709..18481686c47feb3858127d44048b27e172af6bb3 100644

--- a/chrome/browser/ui/extensions/extension_install_ui_default.cc

+++ b/chrome/browser/ui/extensions/extension_install_ui_default.cc

@@ -211,8 +211,7 @@ void ExtensionInstallUIDefault::OnInstallFailure(

if (disable_failure_ui_for_tests() || skip_post_install_ui_)

return;

- Browser* browser =

- chrome::FindLastActiveWithProfile(profile_, chrome::GetActiveDesktop());

+ Browser* browser = chrome::FindLastActiveWithProfile(profile_);

if (!browser) // Can be NULL in unittests.

return;

WebContents* web_contents =

@@ -256,8 +255,7 @@ void ExtensionInstallUIDefault::SetSkipPostInstallUI(bool skip_ui) {

}

gfx::NativeWindow ExtensionInstallUIDefault::GetDefaultInstallDialogParent() {

- Browser* browser =

- chrome::FindLastActiveWithProfile(profile_, chrome::GetActiveDesktop());

+ Browser* browser = chrome::FindLastActiveWithProfile(profile_);

if (browser) {

content::WebContents* contents =

browser->tab_strip_model()->GetActiveWebContents();