DevTools: promisify ContentProvider.requestContent and all its clients.

DevTools: promisify ContentProvider.requestContent and all its clients.

R=pfeldman, dgozman

Committed: https://crrev.com/0dbfb9d1a274bcd95446e82e88820b831bee34f0
Cr-Commit-Position: refs/heads/master@{#370790}

[lushnikov, 2016-01-20 01:50:52]

ptal

[lushnikov, 2016-01-20 01:54:21]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-20 01:55:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1609973002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1609973002/40001

[commit-bot: I haz the power, 2016-01-20 02:30:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 02:30:21]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[pfeldman, 2016-01-20 04:03:57]

(+389 lines, -305 lines) - seems like a negative net. why is it necessary?

[lushnikov, 2016-01-20 08:04:52]

On 2016/01/20 04:03:57, pfeldman wrote:
> (+389 lines, -305 lines) - seems like a negative net. why is it necessary?

(I believe) it is a positive net for the devtools/front_end directory. Most of
the lines gain comes from tests.

[pfeldman, 2016-01-20 19:23:51]

https://codereview.chromium.org/1609973002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/script-formatter-console.html
(right):

https://codereview.chromium.org/1609973002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/script-formatter-console.html:54:
formatVisibleSourceFrame(uiSourceCodeScriptFormatted);
InspectorTest.showScriptSource

https://codereview.chromium.org/1609973002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/sources/debugger/file-system-project-mapping.html
(right):

https://codereview.chromium.org/1609973002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sources/debugger/file-system-project-mapping.html:173:
resourceScriptMapping.scriptFile(uiSourceCode).checkMapping().then(onMappingChecked1);
What if checkMapping is not called in the non-test environment?

https://codereview.chromium.org/1609973002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/ContentProviders.js
(right):

https://codereview.chromium.org/1609973002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/ContentProviders.js:68: var
callback;
cache promise

https://codereview.chromium.org/1609973002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js (right):

https://codereview.chromium.org/1609973002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js:952: return
promise;
cache promise

https://codereview.chromium.org/1609973002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/Resource.js (right):

https://codereview.chromium.org/1609973002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/Resource.js:222: var promise =
new Promise(fulfill => callback = fulfill);
cache promise

https://codereview.chromium.org/1609973002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/Script.js (right):

https://codereview.chromium.org/1609973002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/Script.js:151: var promise =
new Promise(fulfill => callback = fulfill);
cache promise

https://codereview.chromium.org/1609973002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sources/RevisionHistoryView.js
(right):

https://codereview.chromium.org/1609973002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/RevisionHistoryView.js:232:
this._revision.requestContent()
merge this below via push, use ternary operator for the first array item.

Promise.all([
    this._baseRevision ? this._baseRevision.requestContent() :
this.resion.uiSourceCode.requestOriginalContent(),
    this._revision.requestContent()
]).spread(diff.bind(this));

https://codereview.chromium.org/1609973002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
(right):

https://codereview.chromium.org/1609973002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:231: if
(this._content || this._contentLoaded)
return this._requestContentPromise if we have one.

[lushnikov, 2016-01-20 23:35:58]

https://codereview.chromium.org/1609973002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/script-formatter-console.html
(right):

https://codereview.chromium.org/1609973002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/script-formatter-console.html:54:
formatVisibleSourceFrame(uiSourceCodeScriptFormatted);
On 2016/01/20 19:23:51, pfeldman wrote:
> InspectorTest.showScriptSource

Done.

https://codereview.chromium.org/1609973002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/sources/debugger/file-system-project-mapping.html
(right):

https://codereview.chromium.org/1609973002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sources/debugger/file-system-project-mapping.html:173:
resourceScriptMapping.scriptFile(uiSourceCode).checkMapping().then(onMappingChecked1);
On 2016/01/20 19:23:51, pfeldman wrote:
> What if checkMapping is not called in the non-test environment?

Rewrote using sniffers.

https://codereview.chromium.org/1609973002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/ContentProviders.js
(right):

https://codereview.chromium.org/1609973002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/ContentProviders.js:68: var
callback;
This patch is big enough and does its job. The caching thing is not going to be
a trivial change - let's not mix things up.

https://codereview.chromium.org/1609973002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sources/RevisionHistoryView.js
(right):

https://codereview.chromium.org/1609973002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/RevisionHistoryView.js:232:
this._revision.requestContent()
On 2016/01/20 19:23:51, pfeldman wrote:
> merge this below via push, use ternary operator for the first array item.
> 
> Promise.all([
>     this._baseRevision ? this._baseRevision.requestContent() :
> this.resion.uiSourceCode.requestOriginalContent(),
>     this._revision.requestContent()
> ]).spread(diff.bind(this));

Done.

https://codereview.chromium.org/1609973002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
(right):

https://codereview.chromium.org/1609973002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:231: if
(this._content || this._contentLoaded)
On 2016/01/20 19:23:51, pfeldman wrote:
> return this._requestContentPromise if we have one.

Acknowledged.

[pfeldman, 2016-01-21 19:25:50]

lgtm

[lushnikov, 2016-01-21 19:26:15]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-01-21 19:27:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1609973002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1609973002/80001

[commit-bot: I haz the power, 2016-01-21 21:28:07]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-01-21 21:29:41]

Description was changed from

==========
DevTools: promisify ContentProvider.requestContent and all its clients.

R=pfeldman, dgozman
==========

to

==========
DevTools: promisify ContentProvider.requestContent and all its clients.

R=pfeldman, dgozman

Committed: https://crrev.com/0dbfb9d1a274bcd95446e82e88820b831bee34f0
Cr-Commit-Position: refs/heads/master@{#370790}
==========

[commit-bot: I haz the power, 2016-01-21 21:29:42]

Patchset 5 (id:??) landed as
https://crrev.com/0dbfb9d1a274bcd95446e82e88820b831bee34f0
Cr-Commit-Position: refs/heads/master@{#370790}