third_party/WebKit/Source/devtools/front_end/sdk/ContentProviders.js - Issue 1609973002: DevTools: promisify ContentProvider.requestContent and all its clients.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/ContentProviders.js

Issue 1609973002: DevTools: promisify ContentProvider.requestContent and all its clients. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js ('k') | third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sdk/ContentProviders.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/ContentProviders.js b/third_party/WebKit/Source/devtools/front_end/sdk/ContentProviders.js

index f743434ded65b0a2e3bcab98d23cbec59023b0dd..db9eebe8510448458815e35fad5aa180159f7cfb 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/ContentProviders.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/ContentProviders.js

@@ -61,11 +61,14 @@ WebInspector.CompilerSourceMappingContentProvider.prototype = {

/**

* @override

- * @param {function(?string)} callback

+ * @return {!Promise<?string>}

- requestContent: function(callback)

+ requestContent: function()

{

+ var callback;

+ var promise = new Promise(fulfill => callback = fulfill);

WebInspector.multitargetNetworkManager.loadResource(this._sourceURL, contentLoaded.bind(this));

+ return promise;

/**

* @param {number} statusCode

@@ -94,7 +97,7 @@ WebInspector.CompilerSourceMappingContentProvider.prototype = {

searchInContent: function(query, caseSensitive, isRegex, callback)

{

- this.requestContent(contentLoaded);

+ this.requestContent().then(contentLoaded);

/**

* @param {?string} content