third_party/WebKit/LayoutTests/http/tests/inspector/stylesheet-source-mapping.html - Issue 1609973002: DevTools: promisify ContentProvider.requestContent and all its clients.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/stylesheet-source-mapping.html

Issue 1609973002: DevTools: promisify ContentProvider.requestContent and all its clients. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/search/search-in-static.html ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/stylesheet-source-mapping.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/stylesheet-source-mapping.html b/third_party/WebKit/LayoutTests/http/tests/inspector/stylesheet-source-mapping.html

index a990004b4d986fa66d1b98e62398f942cb9c1711..87a7777a8d13c625807bd94def2f959afeb2c7f1 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/stylesheet-source-mapping.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/stylesheet-source-mapping.html

@@ -52,9 +52,9 @@ function test()

const documentURL = "http://localhost:8000/inspector/stylesheet-source-mapping.html";

const frame = InspectorTest.resourceTreeModel.mainFrame;

var resource = new WebInspector.Resource(target, null, url, documentURL, frame.id, frame.loaderId, WebInspector.resourceTypes.Stylesheet, mimeType);

- resource.requestContent = function(callback)

+ resource.requestContent = function()

{

- callback(content, false, mimeType);

+ return Promise.resolve(content);

}

return resource;

}

@@ -94,7 +94,7 @@ function test()

InspectorTest.checkUILocation(scssUISourceCode, 4, 11, rawLocationToUILocation(4, 11));

InspectorTest.checkUILocation(scssUISourceCode, 4, 13, rawLocationToUILocation(4, 15));

InspectorTest.checkUILocation(scssUISourceCode, 4, 17, rawLocationToUILocation(4, 20));

- scssUISourceCode.requestContent(didRequestContent);

+ scssUISourceCode.requestContent().then(didRequestContent);

function didRequestContent(content, contentEncoded, mimeType)

{