third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js - Issue 1609973002: DevTools: promisify ContentProvider.requestContent and all its clients.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js

Issue 1609973002: DevTools: promisify ContentProvider.requestContent and all its clients. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/bindings/ContentProviderBasedProject.js ('k') | third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js

diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js b/third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js

index f8dd6d2a066efe5557a7fbe94381d1677f8023fc..f37057508ed3abc9ecee07e6e1022d199a85d3f3 100644

--- a/third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js

+++ b/third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js

@@ -424,11 +424,11 @@ WebInspector.ResourceScriptFile.prototype = {

checkMapping: function()

{

- if (!this._script)

- return;

- if (typeof this._scriptSource !== "undefined")

+ if (!this._script || typeof this._scriptSource !== "undefined") {

+ this._mappingCheckedForTest();

return;

- this._script.requestContent(callback.bind(this));

+ }

+ this._script.requestContent().then(callback.bind(this));

/**

* @param {?string} source

@@ -438,9 +438,12 @@ WebInspector.ResourceScriptFile.prototype = {

{

this._scriptSource = source;

this._update();

+ this._mappingCheckedForTest();

}

+ _mappingCheckedForTest: function() { },

/**

* @return {?WebInspector.Target}