third_party/WebKit/Source/devtools/front_end/network/HARWriter.js - Issue 1609973002: DevTools: promisify ContentProvider.requestContent and all its clients.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/HARWriter.js

Issue 1609973002: DevTools: promisify ContentProvider.requestContent and all its clients. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js ('k') | third_party/WebKit/Source/devtools/front_end/network/NetworkItemView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/HARWriter.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/HARWriter.js b/third_party/WebKit/Source/devtools/front_end/network/HARWriter.js

index a5ed27a5ce27e642d29933feaa87e294d1401ab6..a460f03ca3dc5d0c4d3509e7c2ec4179e0234cfa 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/HARWriter.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/HARWriter.js

@@ -51,7 +51,7 @@ WebInspector.HARWriter.prototype = {

var content = requests[i].content;

if (typeof content === "undefined" && requests[i].finished) {

++this._pendingRequests;

- requests[i].requestContent(this._onContentAvailable.bind(this, entries[i], requests[i]));

+ requests[i].requestContent().then(this._onContentAvailable.bind(this, entries[i], requests[i]));

} else if (content !== null)

this._setEntryContent(entries[i], requests[i]);

}