third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/debugger-reload-breakpoints-with-source-maps.html - Issue 1609973002: DevTools: promisify ContentProvider.requestContent and all its clients.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/debugger-reload-breakpoints-with-source-maps.html

Issue 1609973002: DevTools: promisify ContentProvider.requestContent and all its clients. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sass/test-mapping-good.html ('k') | third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-checkContent.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/debugger-reload-breakpoints-with-source-maps.html

diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/debugger-reload-breakpoints-with-source-maps.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/debugger-reload-breakpoints-with-source-maps.html

index f167b2ed4577777a228884fb8c24c0aa1acb1533..2c9941fbd3ffcbe3e85d2d7a0023e02fcb6b3869 100644

--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/debugger-reload-breakpoints-with-source-maps.html

+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/debugger-reload-breakpoints-with-source-maps.html

@@ -26,12 +26,17 @@ var test = function()

function didSetBreakpointInDebugger()

{

counter--;

- if (!counter) {

- //Both breakpoints are resolved before reload

- InspectorTest.dumpBreakpointSidebarPane("Breakpoints before reload:");

- waitForBreakpoints();

- InspectorTest.reloadPage(onPageReloaded);

- }

+ if (counter)

+ return;

+ //Both breakpoints are resolved before reload

+ InspectorTest.addSniffer(WebInspector.JavaScriptBreakpointsSidebarPane.prototype, "didReceiveBreakpointLineForTest", onBreakpointsReady);

+ }

+ function onBreakpointsReady()

+ {

+ InspectorTest.dumpBreakpointSidebarPane("Breakpoints before reload:");

+ waitForBreakpoints();

+ InspectorTest.reloadPage(onPageReloaded);

}

function waitForBreakpoints()