third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xhr-sync.html - Issue 1609973002: DevTools: promisify ContentProvider.requestContent and all its clients.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xhr-sync.html

Issue 1609973002: DevTools: promisify ContentProvider.requestContent and all its clients. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xhr-redirect-method.html ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/network/ping-response.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xhr-sync.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xhr-sync.html b/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xhr-sync.html

index 58b9e16237ea22ab82956e0f440ab85a86cd71cd..52b35d5d8505e1ee7e4f7a1dd88265788d83ed8b 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xhr-sync.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xhr-sync.html

@@ -15,7 +15,7 @@ function test()

InspectorTest.addResult("resource.type: " + request1.resourceType());

InspectorTest.addResult("resource.content before requesting content: " + request1.content);

InspectorTest.assertTrue(!request1.failed, "Resource loading failed.");

- request1.requestContent(step3);

+ request1.requestContent().then(step3);

}

function step3()