third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/ui-source-code.html - Issue 1609973002: DevTools: promisify ContentProvider.requestContent and all its clients.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/ui-source-code.html

Issue 1609973002: DevTools: promisify ContentProvider.requestContent and all its clients. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/scripts-with-same-source-url.html ('k') | third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/ui-source-code-display-name.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/ui-source-code.html

diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/ui-source-code.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/ui-source-code.html

index f19204fab138b5d034585f1c85441e0a891dab08..732d512832784fbb4c88850c2a385a05224a9776 100644

--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/ui-source-code.html

+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/ui-source-code.html

@@ -28,7 +28,7 @@ function test()

if (callNumber === 3) {

// Check that sourceCodeProvider.requestContent won't be called anymore.

- uiSourceCode.requestContent(function(content)

+ uiSourceCode.requestContent().then(function(content)

{

InspectorTest.assertEquals("text/javascript", WebInspector.NetworkProject.uiSourceCodeMimeType(uiSourceCode));

InspectorTest.assertEquals("var x = 0;", content);

@@ -37,9 +37,9 @@ function test()

}

// Check that all callbacks will be invoked.

- uiSourceCode.requestContent(didRequestContent.bind(null, 1));

- uiSourceCode.requestContent(didRequestContent.bind(null, 2));

- uiSourceCode.requestContent(didRequestContent.bind(null, 3));

+ uiSourceCode.requestContent().then(didRequestContent.bind(null, 1));

+ uiSourceCode.requestContent().then(didRequestContent.bind(null, 2));

+ uiSourceCode.requestContent().then(didRequestContent.bind(null, 3));

}

]);

};