third_party/WebKit/Source/devtools/front_end/network/RequestResponseView.js - Issue 1609973002: DevTools: promisify ContentProvider.requestContent and all its clients.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/RequestResponseView.js

Issue 1609973002: DevTools: promisify ContentProvider.requestContent and all its clients. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js ('k') | third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/RequestResponseView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/RequestResponseView.js b/third_party/WebKit/Source/devtools/front_end/network/RequestResponseView.js

index 18ad5134b83377cb3019ba02acbaaa9e40c9ebde..b68114a0106b35c8eb6deed86dd61dd08bee1703 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/RequestResponseView.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/RequestResponseView.js

@@ -119,9 +119,9 @@ WebInspector.RequestResponseView.ContentProvider.prototype = {

/**

* @override

- * @param {function(?string)} callback

+ * @return {!Promise<?string>}

- requestContent: function(callback)

+ requestContent: function()

{

/**

* @param {?string} content

@@ -129,10 +129,11 @@ WebInspector.RequestResponseView.ContentProvider.prototype = {

function decodeContent(content)

{

- callback(this._request.contentEncoded ? window.atob(content || "") : content);

+ return this._request.contentEncoded ? window.atob(content || "") : content;

}

- this._request.requestContent(decodeContent.bind(this));

+ return this._request.requestContent()

+ .then(decodeContent.bind(this));

/**