Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1581253003: Add missing 'hard_dependency' in gyp targets using grit_action (Closed)

Created:
4 years, 11 months ago by droger
Modified:
4 years, 7 months ago
Reviewers:
Nico, blundell
CC:
chromium-reviews, sadrul, chromoting-reviews_chromium.org, achuith+watch_chromium.org, rginda+watch_chromium.org, scheib+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, Matt Giuca, lcwu+watch_chromium.org, dzhioev+watch_chromium.org, jam, dglazkov+blink, darin-cc_chromium.org, halliwell+watch_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, blink-reviews-api_chromium.org, tapted, oshima+watch_chromium.org, kalyank, gunsch+watch_chromium.org, tfarina, android-webview-reviews_chromium.org, mtomasz+watch_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing 'hard_dependency' in gyp targets using grit_action The hard dependency is added to all the targets instead of just being added to grit_target.gypi, because grit_target.gypi is slated for deletion and should not be used anymore. BUG=576277

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -6 lines) Patch
M android_webview/android_webview.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ash/ash_resources.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ash/ash_strings.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_resources.gyp View 8 chunks +10 lines, -4 lines 0 comments Download
M chromecast/chromecast.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/chromecast_locales.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M cloud_print/service/service.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M cloud_print/virtual_driver/win/install/virtual_driver_install.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/chrome_apps.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/components_resources.gyp View 2 chunks +1 line, -1 line 0 comments Download
M components/components_strings.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M content/app/resources/content_resources.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M content/app/strings/content_strings.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/devtools/devtools_resources.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_resources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_shell.gypi View 2 chunks +2 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_strings.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M docs/closure_compilation.md View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/extensions_resources.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/extensions_strings.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/shell/app_shell_resources.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M net/net.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/remoting.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/blink_resources.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/libaddressinput/libaddressinput.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/app_list/resources/app_list_resources.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/chromeos/ui_chromeos.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/keyboard/keyboard.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/login/login.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/resources/ui_resources.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/strings/ui_strings.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/resources/views_resources.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
droger
4 years, 11 months ago (2016-01-14 12:13:21 UTC) #7
blundell
lgtm
4 years, 11 months ago (2016-01-14 15:27:55 UTC) #8
droger
thakis: ping
4 years, 11 months ago (2016-01-19 10:01:39 UTC) #9
droger
thakis: ping
4 years, 11 months ago (2016-01-20 09:32:30 UTC) #10
droger
4 years, 7 months ago (2016-05-20 09:38:35 UTC) #11
This is old now, and no longer blocks me. Closing.

Powered by Google App Engine
This is Rietveld 408576698