Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Side by Side Diff: docs/closure_compilation.md

Issue 1581253003: Add missing 'hard_dependency' in gyp targets using grit_action (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « device/bluetooth/bluetooth_strings.gyp ('k') | extensions/extensions_resources.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Closure Compilation 1 # Closure Compilation
2 2
3 ## I just need to fix the compile! 3 ## I just need to fix the compile!
4 4
5 To locally run closure compiler like the bots, do this: 5 To locally run closure compiler like the bots, do this:
6 6
7 ```shell 7 ```shell
8 cd $CHROMIUM_SRC 8 cd $CHROMIUM_SRC
9 # sudo apt-get install openjdk-7-jre # may be required 9 # sudo apt-get install openjdk-7-jre # may be required
10 GYP_GENERATORS=ninja tools/gyp/gyp --depth . \ 10 GYP_GENERATORS=ninja tools/gyp/gyp --depth . \
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
145 # Copyright 2015 The Chromium Authors. All rights reserved. 145 # Copyright 2015 The Chromium Authors. All rights reserved.
146 # Use of this source code is governed by a BSD-style license that can be 146 # Use of this source code is governed by a BSD-style license that can be
147 # found in the LICENSE file. 147 # found in the LICENSE file.
148 148
149 { 149 {
150 'targets': [ 150 'targets': [
151 { 151 {
152 # GN version: //my_project/resources 152 # GN version: //my_project/resources
153 'target_name': 'my_project_resources', 153 'target_name': 'my_project_resources',
154 'type': 'none', 154 'type': 'none',
155 'hard_dependency': 1,
155 'variables': { 156 'variables': {
156 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/my_project', 157 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/my_project',
157 'my_file_gen_js': '<(SHARED_INTERMEDIATE_DIR)/closure/my_project/my_file .js', 158 'my_file_gen_js': '<(SHARED_INTERMEDIATE_DIR)/closure/my_project/my_file .js',
158 }, 159 },
159 'actions': [ 160 'actions': [
160 { 161 {
161 # GN version: //my_project/resources:my_project_resources 162 # GN version: //my_project/resources:my_project_resources
162 'action_name': 'generate_my_project_resources', 163 'action_name': 'generate_my_project_resources',
163 'variables': { 164 'variables': {
164 'grit_grd_file': 'resources/my_project_resources.grd', 165 'grit_grd_file': 'resources/my_project_resources.grd',
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
272 'jscomp_error=duplicate', 273 'jscomp_error=duplicate',
273 'jscomp_error=misplacedTypeAnnotation', 274 'jscomp_error=misplacedTypeAnnotation',
274 ], 275 ],
275 'disabled_closure_args': [], # remove the disabled closure args for more strict compilation 276 'disabled_closure_args': [], # remove the disabled closure args for more strict compilation
276 }, 277 },
277 'includes': ['../third_party/closure_compiler/compile_js.gypi'], 278 'includes': ['../third_party/closure_compiler/compile_js.gypi'],
278 }, 279 },
279 ], 280 ],
280 } 281 }
281 ``` 282 ```
OLDNEW
« no previous file with comments | « device/bluetooth/bluetooth_strings.gyp ('k') | extensions/extensions_resources.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698