Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Side by Side Diff: ui/strings/ui_strings.gyp

Issue 1581253003: Add missing 'hard_dependency' in gyp targets using grit_action (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/resources/ui_resources.gyp ('k') | ui/views/resources/views_resources.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'targets': [ 6 'targets': [
7 { 7 {
8 'target_name': 'ui_strings', 8 'target_name': 'ui_strings',
9 'type': 'none', 9 'type': 'none',
10 'hard_dependency': 1,
10 'variables': { 11 'variables': {
11 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/ui/strings', 12 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/ui/strings',
12 }, 13 },
13 'actions': [ 14 'actions': [
14 { 15 {
15 'action_name': 'generate_ui_strings', 16 'action_name': 'generate_ui_strings',
16 'variables': { 17 'variables': {
17 'grit_grd_file': 'ui_strings.grd', 18 'grit_grd_file': 'ui_strings.grd',
18 }, 19 },
19 'includes': [ '../../build/grit_action.gypi' ], 20 'includes': [ '../../build/grit_action.gypi' ],
20 }, 21 },
21 { 22 {
22 'action_name': 'generate_app_locale_settings', 23 'action_name': 'generate_app_locale_settings',
23 'variables': { 24 'variables': {
24 'grit_grd_file': 'app_locale_settings.grd', 25 'grit_grd_file': 'app_locale_settings.grd',
25 }, 26 },
26 'includes': [ '../../build/grit_action.gypi' ], 27 'includes': [ '../../build/grit_action.gypi' ],
27 }, 28 },
28 ], 29 ],
29 }, 30 },
30 ], 31 ],
31 } 32 }
OLDNEW
« no previous file with comments | « ui/resources/ui_resources.gyp ('k') | ui/views/resources/views_resources.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698