Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Side by Side Diff: ui/login/login.gyp

Issue 1581253003: Add missing 'hard_dependency' in gyp targets using grit_action (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/keyboard/keyboard.gyp ('k') | ui/resources/ui_resources.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'chromium_code': 1, 7 'chromium_code': 1,
8 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/ui/login', 8 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/ui/login',
9 }, 9 },
10 'targets': [ 10 'targets': [
11 { 11 {
12 # TODO bug 512913 support in GN. 12 # TODO bug 512913 support in GN.
13 'target_name': 'login_resources', 13 'target_name': 'login_resources',
14 'type': 'none', 14 'type': 'none',
15 'hard_dependency': 1,
15 'actions': [ 16 'actions': [
16 { 17 {
17 'action_name': 'login_resources', 18 'action_name': 'login_resources',
18 'variables': { 19 'variables': {
19 'grit_grd_file': 'login_resources.grd', 20 'grit_grd_file': 'login_resources.grd',
20 }, 21 },
21 'includes': [ '../../build/grit_action.gypi' ], 22 'includes': [ '../../build/grit_action.gypi' ],
22 }, 23 },
23 ], 24 ],
24 'includes': [ '../../build/grit_target.gypi' ], 25 'includes': [ '../../build/grit_target.gypi' ],
25 'copies': [ 26 'copies': [
26 { 27 {
27 'destination': '<(PRODUCT_DIR)', 28 'destination': '<(PRODUCT_DIR)',
28 'files': [ 29 'files': [
29 '<(SHARED_INTERMEDIATE_DIR)/ui/login/login_resources.pak', 30 '<(SHARED_INTERMEDIATE_DIR)/ui/login/login_resources.pak',
30 ], 31 ],
31 }, 32 },
32 ], 33 ],
33 }, 34 },
34 ], 35 ],
35 } 36 }
OLDNEW
« no previous file with comments | « ui/keyboard/keyboard.gyp ('k') | ui/resources/ui_resources.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698