Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Side by Side Diff: content/app/strings/content_strings.gyp

Issue 1581253003: Add missing 'hard_dependency' in gyp targets using grit_action (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'targets': [ 6 'targets': [
7 { 7 {
8 # GN version: //content/app/strings 8 # GN version: //content/app/strings
9 'target_name': 'content_strings', 9 'target_name': 'content_strings',
10 'type': 'none', 10 'type': 'none',
11 'hard_dependency': 1,
11 'variables': { 12 'variables': {
12 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/content/app/strings', 13 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/content/app/strings',
13 }, 14 },
14 'actions': [ 15 'actions': [
15 { 16 {
16 'action_name': 'generate_content_strings', 17 'action_name': 'generate_content_strings',
17 'variables': { 18 'variables': {
18 'grit_grd_file': 'content_strings.grd', 19 'grit_grd_file': 'content_strings.grd',
19 }, 20 },
20 'includes': [ '../../../build/grit_action.gypi' ], 21 'includes': [ '../../../build/grit_action.gypi' ],
21 }, 22 },
22 ], 23 ],
23 'direct_dependent_settings': { 24 'direct_dependent_settings': {
24 'include_dirs': [ 25 'include_dirs': [
25 '<(SHARED_INTERMEDIATE_DIR)', 26 '<(SHARED_INTERMEDIATE_DIR)',
26 ], 27 ],
27 }, 28 },
28 }, 29 },
29 ] 30 ]
30 } 31 }
OLDNEW
« no previous file with comments | « content/app/resources/content_resources.gyp ('k') | content/browser/devtools/devtools_resources.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698