content/content_shell.gypi - Issue 1581253003: Add missing 'hard_dependency' in gyp targets using grit_action

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/content_shell.gypi

Issue 1581253003: Add missing 'hard_dependency' in gyp targets using grit_action (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/content_shell.gypi

diff --git a/content/content_shell.gypi b/content/content_shell.gypi

index 35e849bed91e7ff67aa5b41c2ca270cb37b57933..c73b4a403ba0dae60b7341fc64b73fb7d4ffff06 100644

--- a/content/content_shell.gypi

+++ b/content/content_shell.gypi

@@ -341,6 +341,7 @@

# GN version: //content/shell:resources

'target_name': 'content_shell_resources',

'type': 'none',

+ 'hard_dependency': 1,

'variables': {

'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/content',

@@ -927,7 +928,7 @@

}],

- 'includes': [

+ 'includes': [

'../build/android/v8_external_startup_data_arch_suffix.gypi',

'../build/java_apk.gypi',

« no previous file with comments | « content/content_resources.gypi ('k') | device/bluetooth/bluetooth_strings.gyp » ('j') | no next file with comments »