Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: extensions/extensions_resources.gyp

Issue 1581253003: Add missing 'hard_dependency' in gyp targets using grit_action (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « docs/closure_compilation.md ('k') | extensions/extensions_strings.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'targets': [ 6 'targets': [
7 { 7 {
8 'target_name': 'extensions_resources', 8 'target_name': 'extensions_resources',
9 'type': 'none', 9 'type': 'none',
10 'hard_dependency': 1,
10 'variables': { 11 'variables': {
11 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/extensions', 12 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/extensions',
12 }, 13 },
13 'dependencies': [ 14 'dependencies': [
14 'common/api/api.gyp:extensions_api_mojom', 15 'common/api/api.gyp:extensions_api_mojom',
15 '../device/serial/serial.gyp:device_serial_mojo', 16 '../device/serial/serial.gyp:device_serial_mojo',
16 ], 17 ],
17 'actions': [ 18 'actions': [
18 { 19 {
19 'action_name': 'generate_extensions_resources', 20 'action_name': 'generate_extensions_resources',
(...skipping 17 matching lines...) Expand all
37 '-E', 'mojom_root=<(SHARED_INTERMEDIATE_DIR)', 38 '-E', 'mojom_root=<(SHARED_INTERMEDIATE_DIR)',
38 ], 39 ],
39 }, 40 },
40 'includes': [ '../build/grit_action.gypi' ], 41 'includes': [ '../build/grit_action.gypi' ],
41 }, 42 },
42 ], 43 ],
43 'includes': [ '../build/grit_target.gypi' ], 44 'includes': [ '../build/grit_target.gypi' ],
44 } 45 }
45 ] 46 ]
46 } 47 }
OLDNEW
« no previous file with comments | « docs/closure_compilation.md ('k') | extensions/extensions_strings.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698