Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Side by Side Diff: third_party/WebKit/public/blink_resources.gyp

Issue 1581253003: Add missing 'hard_dependency' in gyp targets using grit_action (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « remoting/remoting.gyp ('k') | third_party/libaddressinput/libaddressinput.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'targets': [ 6 'targets': [
7 { 7 {
8 'target_name': 'blink_resources', 8 'target_name': 'blink_resources',
9 'type': 'none', 9 'type': 'none',
10 'hard_dependency': 1,
10 'variables': { 11 'variables': {
11 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/blink/public/resources', 12 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/blink/public/resources',
12 }, 13 },
13 'actions': [ 14 'actions': [
14 { 15 {
15 'action_name': 'generate_blink_resources', 16 'action_name': 'generate_blink_resources',
16 'variables': { 17 'variables': {
17 'grit_grd_file': 'blink_resources.grd', 18 'grit_grd_file': 'blink_resources.grd',
18 }, 19 },
19 'includes': [ '../../../build/grit_action.gypi' ], 20 'includes': [ '../../../build/grit_action.gypi' ],
20 }, 21 },
21 ], 22 ],
22 'direct_dependent_settings': { 23 'direct_dependent_settings': {
23 'include_dirs': [ 24 'include_dirs': [
24 '<(SHARED_INTERMEDIATE_DIR)', 25 '<(SHARED_INTERMEDIATE_DIR)',
25 ], 26 ],
26 }, 27 },
27 }, 28 },
28 { 29 {
29 'target_name': 'blink_image_resources', 30 'target_name': 'blink_image_resources',
30 'type': 'none', 31 'type': 'none',
32 'hard_dependency': 1,
31 'variables': { 33 'variables': {
32 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/blink/public/resources', 34 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/blink/public/resources',
33 }, 35 },
34 'actions': [ 36 'actions': [
35 { 37 {
36 'action_name': 'generate_blink_image_resources', 38 'action_name': 'generate_blink_image_resources',
37 'variables': { 39 'variables': {
38 'grit_grd_file': 'blink_image_resources.grd', 40 'grit_grd_file': 'blink_image_resources.grd',
39 }, 41 },
40 'includes': [ '../../../build/grit_action.gypi' ], 42 'includes': [ '../../../build/grit_action.gypi' ],
41 }, 43 },
42 ], 44 ],
43 'direct_dependent_settings': { 45 'direct_dependent_settings': {
44 'include_dirs': [ 46 'include_dirs': [
45 '<(SHARED_INTERMEDIATE_DIR)', 47 '<(SHARED_INTERMEDIATE_DIR)',
46 ], 48 ],
47 }, 49 },
48 }, 50 },
49 ], 51 ],
50 } 52 }
OLDNEW
« no previous file with comments | « remoting/remoting.gyp ('k') | third_party/libaddressinput/libaddressinput.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698