Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Side by Side Diff: cloud_print/virtual_driver/win/install/virtual_driver_install.gyp

Issue 1581253003: Add missing 'hard_dependency' in gyp targets using grit_action (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cloud_print/service/service.gyp ('k') | components/chrome_apps.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'target_defaults': { 6 'target_defaults': {
7 'variables': { 7 'variables': {
8 'chromium_code': 1, 8 'chromium_code': 1,
9 }, 9 },
10 'include_dirs': [ 10 'include_dirs': [
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 'files': [ 99 'files': [
100 '../../gcp_driver.gpd', 100 '../../gcp_driver.gpd',
101 ], 101 ],
102 }, 102 },
103 ], 103 ],
104 }, 104 },
105 { 105 {
106 # GN version: //cloud_print/virtual_driver/win/install:resources 106 # GN version: //cloud_print/virtual_driver/win/install:resources
107 'target_name': 'virtual_driver_setup_resources', 107 'target_name': 'virtual_driver_setup_resources',
108 'type': 'none', 108 'type': 'none',
109 'hard_dependency': 1,
109 'variables': { 110 'variables': {
110 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/virtual_driver_setup_resourc es', 111 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/virtual_driver_setup_resourc es',
111 }, 112 },
112 'actions': [ 113 'actions': [
113 { 114 {
114 'action_name': 'virtual_driver_setup_resources', 115 'action_name': 'virtual_driver_setup_resources',
115 'variables': { 116 'variables': {
116 'grit_grd_file': 'virtual_driver_setup_resources.grd', 117 'grit_grd_file': 'virtual_driver_setup_resources.grd',
117 }, 118 },
118 'includes': [ '../../../../build/grit_action.gypi' ], 119 'includes': [ '../../../../build/grit_action.gypi' ],
119 }, 120 },
120 ], 121 ],
121 'includes': [ '../../../../build/grit_target.gypi' ], 122 'includes': [ '../../../../build/grit_target.gypi' ],
122 }, 123 },
123 ], 124 ],
124 } 125 }
OLDNEW
« no previous file with comments | « cloud_print/service/service.gyp ('k') | components/chrome_apps.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698