Forward the number of skipped frames by the OS in audio playout.

Forward the number of skipped frames by the OS in audio playout.

* Introduce AudioOutputBufferParameters in media/audio/audio_parameters.h. This contains number of skipped frames.
* Change the shared memory to hold AudioOutputBufferParameters before the audio data.
* Forward skipped frames by OS on Mac over IPC. Not yet used by any client.

This relands https://codereview.chromium.org/1487983002/ which was reverted due to crackling flash (pepper) audio.

Original CL is in patch set 1.

Will be done in follow-up CLs:
* Forward skipped frames by OS on Windows.
* Forward skipped frames to the WebRTC AEC.

BUG=560371
TBR=dalecurtis@chromium.org,ckehoe@chromium.org (no changes from original CL)

Committed: https://crrev.com/09a6d7939e02a3b892d3eeaac95c5f0fc36e7e72
Cr-Commit-Position: refs/heads/master@{#366078}

[Henrik Grunell, 2015-12-17 17:12:53]

Description was changed from

==========
Forward the number of skipped frames by the OS in audio playout.

* Only for Mac.

Will be done in follow-up CLs:
* Windows.
* Hooking this up to the AEC.

BUG=560371
==========

to

==========
Forward the number of skipped frames by the OS in audio playout.

* Introduce AudioOutputBufferParameters in media/audio/audio_parameters.h. This
contains number of skipped frames.
* Change the shared memory to hold AudioOutputBufferParameters before the audio
data.
* Forward skipped frames by OS on Mac over IPC. Not yet used by any client.

Will be done in follow-up CLs:
* Forward skipped frames by OS on Windows.
* Forward skipped frames to the WebRTC AEC.

BUG=560371
==========

[Henrik Grunell, 2015-12-17 17:16:30]

Description was changed from

==========
Forward the number of skipped frames by the OS in audio playout.

* Introduce AudioOutputBufferParameters in media/audio/audio_parameters.h. This
contains number of skipped frames.
* Change the shared memory to hold AudioOutputBufferParameters before the audio
data.
* Forward skipped frames by OS on Mac over IPC. Not yet used by any client.

Will be done in follow-up CLs:
* Forward skipped frames by OS on Windows.
* Forward skipped frames to the WebRTC AEC.

BUG=560371
==========

to

==========
Forward the number of skipped frames by the OS in audio playout.

* Introduce AudioOutputBufferParameters in media/audio/audio_parameters.h. This
contains number of skipped frames.
* Change the shared memory to hold AudioOutputBufferParameters before the audio
data.
* Forward skipped frames by OS on Mac over IPC. Not yet used by any client.

This relands https://codereview.chromium.org/1487983002/ which was reverted due
to crackling flash (pepper) audio.

Will be done in follow-up CLs:
* Forward skipped frames by OS on Windows.
* Forward skipped frames to the WebRTC AEC.

BUG=560371
==========

[Henrik Grunell, 2015-12-17 18:10:38]

Description was changed from

==========
Forward the number of skipped frames by the OS in audio playout.

* Introduce AudioOutputBufferParameters in media/audio/audio_parameters.h. This
contains number of skipped frames.
* Change the shared memory to hold AudioOutputBufferParameters before the audio
data.
* Forward skipped frames by OS on Mac over IPC. Not yet used by any client.

This relands https://codereview.chromium.org/1487983002/ which was reverted due
to crackling flash (pepper) audio.

Will be done in follow-up CLs:
* Forward skipped frames by OS on Windows.
* Forward skipped frames to the WebRTC AEC.

BUG=560371
==========

to

==========
Forward the number of skipped frames by the OS in audio playout.

* Introduce AudioOutputBufferParameters in media/audio/audio_parameters.h. This
contains number of skipped frames.
* Change the shared memory to hold AudioOutputBufferParameters before the audio
data.
* Forward skipped frames by OS on Mac over IPC. Not yet used by any client.

This relands https://codereview.chromium.org/1487983002/ which was reverted due
to crackling flash (pepper) audio.

Original CL is in patch set 1.

Will be done in follow-up CLs:
* Forward skipped frames by OS on Windows.
* Forward skipped frames to the WebRTC AEC.

BUG=560371
==========

[Henrik Grunell, 2015-12-17 18:10:38]

grunell@chromium.org changed reviewers:
+ bbudge@chromium.org, tommi@chromium.org

[Henrik Grunell, 2015-12-17 18:14:44]

This fixes pepper audio. Original CL that was reverted is in patch set 1. Diff
against that to see changes.

I could reproduce the issue and verify that it was fixed with the change here.

It was also reported that text-to-speech had the same issues, but I could not
reproduce that. Is there any other audio path that needs to be considered?

[bbudge, 2015-12-17 18:32:57]

ppapi LGTM

https://codereview.chromium.org/1538563002/diff/20001/ppapi/shared_impl/ppb_a...
File ppapi/shared_impl/ppb_audio_shared.cc (right):

https://codereview.chromium.org/1538563002/diff/20001/ppapi/shared_impl/ppb_a...
ppapi/shared_impl/ppb_audio_shared.cc:116:
DCHECK_EQ(static_cast<size_t>(shared_memory_size_),
nit: cast shouldn't be needed.

[halliwell, 2015-12-17 20:27:48]

On 2015/12/17 18:32:57, bbudge wrote:
> ppapi LGTM
> 
>
https://codereview.chromium.org/1538563002/diff/20001/ppapi/shared_impl/ppb_a...
> File ppapi/shared_impl/ppb_audio_shared.cc (right):
> 
>
https://codereview.chromium.org/1538563002/diff/20001/ppapi/shared_impl/ppb_a...
> ppapi/shared_impl/ppb_audio_shared.cc:116:
> DCHECK_EQ(static_cast<size_t>(shared_memory_size_),
> nit: cast shouldn't be needed.

chromecast/ lgtm

[tommi (sloooow) - chröme, 2015-12-17 23:43:15]

lgtm

[Henrik Grunell, 2015-12-18 08:53:03]

https://codereview.chromium.org/1538563002/diff/20001/ppapi/shared_impl/ppb_a...
File ppapi/shared_impl/ppb_audio_shared.cc (right):

https://codereview.chromium.org/1538563002/diff/20001/ppapi/shared_impl/ppb_a...
ppapi/shared_impl/ppb_audio_shared.cc:116:
DCHECK_EQ(static_cast<size_t>(shared_memory_size_),
On 2015/12/17 18:32:57, bbudge wrote:
> nit: cast shouldn't be needed.

Ah. Fixed.

[Henrik Grunell, 2015-12-18 08:55:39]

grunell@chromium.org changed reviewers:
+ dalecurtis@chromium.org, halliwell@chromium.org

[Henrik Grunell, 2015-12-18 08:57:56]

Description was changed from

==========
Forward the number of skipped frames by the OS in audio playout.

* Introduce AudioOutputBufferParameters in media/audio/audio_parameters.h. This
contains number of skipped frames.
* Change the shared memory to hold AudioOutputBufferParameters before the audio
data.
* Forward skipped frames by OS on Mac over IPC. Not yet used by any client.

This relands https://codereview.chromium.org/1487983002/ which was reverted due
to crackling flash (pepper) audio.

Original CL is in patch set 1.

Will be done in follow-up CLs:
* Forward skipped frames by OS on Windows.
* Forward skipped frames to the WebRTC AEC.

BUG=560371
==========

to

==========
Forward the number of skipped frames by the OS in audio playout.

* Introduce AudioOutputBufferParameters in media/audio/audio_parameters.h. This
contains number of skipped frames.
* Change the shared memory to hold AudioOutputBufferParameters before the audio
data.
* Forward skipped frames by OS on Mac over IPC. Not yet used by any client.

This relands https://codereview.chromium.org/1487983002/ which was reverted due
to crackling flash (pepper) audio.

Original CL is in patch set 1.

Will be done in follow-up CLs:
* Forward skipped frames by OS on Windows.
* Forward skipped frames to the WebRTC AEC.

BUG=560371
TBR=dalecurtis@chromium.org,ckehoe@chromium.org (no changes from original CL)
==========

[Henrik Grunell, 2015-12-18 08:57:56]

grunell@chromium.org changed reviewers:
+ ckehoe@chromium.org

[tommi (sloooow) - chröme, 2015-12-18 09:10:56]

On 2015/12/18 08:53:03, Henrik Grunell wrote:
>
https://codereview.chromium.org/1538563002/diff/20001/ppapi/shared_impl/ppb_a...
> File ppapi/shared_impl/ppb_audio_shared.cc (right):
> 
>
https://codereview.chromium.org/1538563002/diff/20001/ppapi/shared_impl/ppb_a...
> ppapi/shared_impl/ppb_audio_shared.cc:116:
> DCHECK_EQ(static_cast<size_t>(shared_memory_size_),
> On 2015/12/17 18:32:57, bbudge wrote:
> > nit: cast shouldn't be needed.
> 
> Ah. Fixed.

Since Dale is out and this is basically the same code review as the last one + a
small change for ppapi, I think it's fine to TBR him.

[Henrik Grunell, 2015-12-18 09:28:53]

On 2015/12/18 09:10:56, tommi wrote:
> On 2015/12/18 08:53:03, Henrik Grunell wrote:
> >
>
https://codereview.chromium.org/1538563002/diff/20001/ppapi/shared_impl/ppb_a...
> > File ppapi/shared_impl/ppb_audio_shared.cc (right):
> > 
> >
>
https://codereview.chromium.org/1538563002/diff/20001/ppapi/shared_impl/ppb_a...
> > ppapi/shared_impl/ppb_audio_shared.cc:116:
> > DCHECK_EQ(static_cast<size_t>(shared_memory_size_),
> > On 2015/12/17 18:32:57, bbudge wrote:
> > > nit: cast shouldn't be needed.
> > 
> > Ah. Fixed.
> 
> Since Dale is out and this is basically the same code review as the last one +
a
> small change for ppapi, I think it's fine to TBR him.

Yep, I already did that. :)

[Henrik Grunell, 2015-12-18 09:29:00]

The CQ bit was checked by grunell@chromium.org

[Henrik Grunell, 2015-12-18 09:29:00]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@chromium.org,
bbudge@chromium.org, halliwell@chromium.org
Link to the patchset: https://codereview.chromium.org/1538563002/#ps40001
(title: "Code review fix. git cl format. Rebase.")

[commit-bot: I haz the power, 2015-12-18 09:29:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1538563002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1538563002/40001

[commit-bot: I haz the power, 2015-12-18 11:28:28]

Description was changed from

==========
Forward the number of skipped frames by the OS in audio playout.

* Introduce AudioOutputBufferParameters in media/audio/audio_parameters.h. This
contains number of skipped frames.
* Change the shared memory to hold AudioOutputBufferParameters before the audio
data.
* Forward skipped frames by OS on Mac over IPC. Not yet used by any client.

This relands https://codereview.chromium.org/1487983002/ which was reverted due
to crackling flash (pepper) audio.

Original CL is in patch set 1.

Will be done in follow-up CLs:
* Forward skipped frames by OS on Windows.
* Forward skipped frames to the WebRTC AEC.

BUG=560371
TBR=dalecurtis@chromium.org,ckehoe@chromium.org (no changes from original CL)
==========

to

==========
Forward the number of skipped frames by the OS in audio playout.

* Introduce AudioOutputBufferParameters in media/audio/audio_parameters.h. This
contains number of skipped frames.
* Change the shared memory to hold AudioOutputBufferParameters before the audio
data.
* Forward skipped frames by OS on Mac over IPC. Not yet used by any client.

This relands https://codereview.chromium.org/1487983002/ which was reverted due
to crackling flash (pepper) audio.

Original CL is in patch set 1.

Will be done in follow-up CLs:
* Forward skipped frames by OS on Windows.
* Forward skipped frames to the WebRTC AEC.

BUG=560371
TBR=dalecurtis@chromium.org,ckehoe@chromium.org (no changes from original CL)
==========

[commit-bot: I haz the power, 2015-12-18 11:28:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-18 11:29:26]

Description was changed from

==========
Forward the number of skipped frames by the OS in audio playout.

* Introduce AudioOutputBufferParameters in media/audio/audio_parameters.h. This
contains number of skipped frames.
* Change the shared memory to hold AudioOutputBufferParameters before the audio
data.
* Forward skipped frames by OS on Mac over IPC. Not yet used by any client.

This relands https://codereview.chromium.org/1487983002/ which was reverted due
to crackling flash (pepper) audio.

Original CL is in patch set 1.

Will be done in follow-up CLs:
* Forward skipped frames by OS on Windows.
* Forward skipped frames to the WebRTC AEC.

BUG=560371
TBR=dalecurtis@chromium.org,ckehoe@chromium.org (no changes from original CL)
==========

to

==========
Forward the number of skipped frames by the OS in audio playout.

* Introduce AudioOutputBufferParameters in media/audio/audio_parameters.h. This
contains number of skipped frames.
* Change the shared memory to hold AudioOutputBufferParameters before the audio
data.
* Forward skipped frames by OS on Mac over IPC. Not yet used by any client.

This relands https://codereview.chromium.org/1487983002/ which was reverted due
to crackling flash (pepper) audio.

Original CL is in patch set 1.

Will be done in follow-up CLs:
* Forward skipped frames by OS on Windows.
* Forward skipped frames to the WebRTC AEC.

BUG=560371
TBR=dalecurtis@chromium.org,ckehoe@chromium.org (no changes from original CL)

Committed: https://crrev.com/09a6d7939e02a3b892d3eeaac95c5f0fc36e7e72
Cr-Commit-Position: refs/heads/master@{#366078}
==========

[commit-bot: I haz the power, 2015-12-18 11:29:28]

Patchset 3 (id:??) landed as
https://crrev.com/09a6d7939e02a3b892d3eeaac95c5f0fc36e7e72
Cr-Commit-Position: refs/heads/master@{#366078}

[Henrik Grunell, 2016-04-05 08:32:11]

Description was changed from

==========
Forward the number of skipped frames by the OS in audio playout.

* Introduce AudioOutputBufferParameters in media/audio/audio_parameters.h. This
contains number of skipped frames.
* Change the shared memory to hold AudioOutputBufferParameters before the audio
data.
* Forward skipped frames by OS on Mac over IPC. Not yet used by any client.

This relands https://codereview.chromium.org/1487983002/ which was reverted due
to crackling flash (pepper) audio.

Original CL is in patch set 1.

Will be done in follow-up CLs:
* Forward skipped frames by OS on Windows.
* Forward skipped frames to the WebRTC AEC.

BUG=560371
TBR=dalecurtis@chromium.org,ckehoe@chromium.org (no changes from original CL)

Committed: https://crrev.com/09a6d7939e02a3b892d3eeaac95c5f0fc36e7e72
Cr-Commit-Position: refs/heads/master@{#366078}
==========

to

==========
Forward the number of skipped frames by the OS in audio playout.

* Introduce AudioOutputBufferParameters in media/audio/audio_parameters.h. This
contains number of skipped frames.
* Change the shared memory to hold AudioOutputBufferParameters before the audio
data.
* Forward skipped frames by OS on Mac over IPC. Not yet used by any client.

This relands https://codereview.chromium.org/1487983002/ which was reverted due
to crackling flash (pepper) audio.

Original CL is in patch set 1.

Will be done in follow-up CLs:
* Forward skipped frames by OS on Windows.
* Forward skipped frames to the WebRTC AEC.

BUG=560371
TBR=dalecurtis@chromium.org,ckehoe@chromium.org (no changes from original CL)

Committed: https://crrev.com/09a6d7939e02a3b892d3eeaac95c5f0fc36e7e72
Cr-Commit-Position: refs/heads/master@{#366078}
==========