media/audio/win/waveout_output_win.cc - Issue 1538563002: Forward the number of skipped frames by the OS in audio playout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/win/waveout_output_win.cc

Issue 1538563002: Forward the number of skipped frames by the OS in audio playout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review fix. git cl format. Rebase. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/audio/win/waveout_output_win.cc

diff --git a/media/audio/win/waveout_output_win.cc b/media/audio/win/waveout_output_win.cc

index 5be9e0a444569dd4c94c62534c6caa613d880cdc..456124dbf2637f4e07d4e29f934dcc2a7618b1fb 100644

--- a/media/audio/win/waveout_output_win.cc

+++ b/media/audio/win/waveout_output_win.cc

@@ -327,8 +327,8 @@ void PCMWaveOutAudioOutputStream::QueueNextPacket(WAVEHDR *buffer) {

// TODO(sergeyu): Specify correct hardware delay for |total_delay_bytes|.

uint32 total_delay_bytes = pending_bytes_;

- int frames_filled = callback_->OnMoreData(

- audio_bus_.get(), total_delay_bytes);

+ int frames_filled =

+ callback_->OnMoreData(audio_bus_.get(), total_delay_bytes, 0);

uint32 used = frames_filled * audio_bus_->channels() *

format_.Format.wBitsPerSample / 8;

« no previous file with comments | « media/audio/win/audio_output_win_unittest.cc ('k') | media/base/audio_bus_perftest.cc » ('j') | no next file with comments »