media/base/audio_renderer_mixer_input.cc - Issue 1538563002: Forward the number of skipped frames by the OS in audio playout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/audio_renderer_mixer_input.cc

Issue 1538563002: Forward the number of skipped frames by the OS in audio playout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review fix. git cl format. Rebase. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/base/audio_renderer_mixer_input.cc

diff --git a/media/base/audio_renderer_mixer_input.cc b/media/base/audio_renderer_mixer_input.cc

index 539cdf3ea50946c57f43127471a54d0f8345dada..d0d38d3b8eef902f69b9a342cdaffcbe0109235b 100644

--- a/media/base/audio_renderer_mixer_input.cc

+++ b/media/base/audio_renderer_mixer_input.cc

@@ -166,7 +166,7 @@ OutputDeviceStatus AudioRendererMixerInput::GetDeviceStatus() {

double AudioRendererMixerInput::ProvideInput(AudioBus* audio_bus,

base::TimeDelta buffer_delay) {

int frames_filled = callback_->Render(

- audio_bus, static_cast<int>(buffer_delay.InMillisecondsF() + 0.5));

+ audio_bus, static_cast<int>(buffer_delay.InMillisecondsF() + 0.5), 0);

// AudioConverter expects unfilled frames to be zeroed.

if (frames_filled < audio_bus->frames()) {

« no previous file with comments | « media/base/audio_renderer_mixer.cc ('k') | media/base/audio_renderer_mixer_unittest.cc » ('j') | no next file with comments »