content/browser/renderer_host/media/audio_renderer_host.cc - Issue 1538563002: Forward the number of skipped frames by the OS in audio playout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/audio_renderer_host.cc

Issue 1538563002: Forward the number of skipped frames by the OS in audio playout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review fix. git cl format. Rebase. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/media/capture/web_contents_audio_muter.cc ('k') | content/browser/renderer_host/media/audio_sync_reader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/audio_renderer_host.cc

diff --git a/content/browser/renderer_host/media/audio_renderer_host.cc b/content/browser/renderer_host/media/audio_renderer_host.cc

index 6e0650c582943c9ce85ff9aa847aebcc5d14c751..29c9d7f81866734f5ed6580c90facbee4464fb2c 100644

--- a/content/browser/renderer_host/media/audio_renderer_host.cc

+++ b/content/browser/renderer_host/media/audio_renderer_host.cc

@@ -569,7 +569,8 @@ void AudioRendererHost::DoCreateStream(int stream_id,

}

// Create the shared memory and share with the renderer process.

- uint32 shared_memory_size = AudioBus::CalculateMemorySize(params);

+ uint32 shared_memory_size = sizeof(media::AudioOutputBufferParameters) +

+ AudioBus::CalculateMemorySize(params);

scoped_ptr<base::SharedMemory> shared_memory(new base::SharedMemory());

if (!shared_memory->CreateAndMapAnonymous(shared_memory_size)) {

SendErrorMessage(stream_id);