media/audio/pulse/pulse_output.cc - Issue 1538563002: Forward the number of skipped frames by the OS in audio playout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/pulse/pulse_output.cc

Issue 1538563002: Forward the number of skipped frames by the OS in audio playout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review fix. git cl format. Rebase. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/audio/pulse/pulse_output.cc

diff --git a/media/audio/pulse/pulse_output.cc b/media/audio/pulse/pulse_output.cc

index 0ba728d9751a54e7592be1da78b4a8796a4fdf16..1077e2503bb0c19db02feba5e0613f7b33d67763 100644

--- a/media/audio/pulse/pulse_output.cc

+++ b/media/audio/pulse/pulse_output.cc

@@ -132,8 +132,8 @@ void PulseAudioOutputStream::FulfillWriteRequest(size_t requested_bytes) {

if (source_callback_) {

const uint32 hardware_delay = pulse::GetHardwareLatencyInBytes(

pa_stream_, params_.sample_rate(), params_.GetBytesPerFrame());

- frames_filled = source_callback_->OnMoreData(

- audio_bus_.get(), hardware_delay);

+ frames_filled =

+ source_callback_->OnMoreData(audio_bus_.get(), hardware_delay, 0);

// Zero any unfilled data so it plays back as silence.

if (frames_filled < audio_bus_->frames()) {

« no previous file with comments | « media/audio/null_audio_sink.cc ('k') | media/audio/simple_sources.h » ('j') | no next file with comments »