Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1519243002: Remove many unused files from //skia/ext (Closed)

Created:
5 years ago by jamesr
Modified:
5 years ago
CC:
mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove many unused files from //skia/ext We don't build for windows or use the custom convolvers etc. R=kulakowski@google.com, viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9498ce03c41ba008bc95900130054318aeb7eaa2

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7207 lines) Patch
M skia/BUILD.gn View 1 11 chunks +16 lines, -138 lines 0 comments Download
D skia/ext/analysis_canvas.h View 1 chunk +0 lines, -135 lines 0 comments Download
D skia/ext/analysis_canvas.cc View 1 chunk +0 lines, -454 lines 0 comments Download
D skia/ext/analysis_canvas_unittest.cc View 1 chunk +0 lines, -394 lines 0 comments Download
D skia/ext/convolver.h View 1 chunk +0 lines, -235 lines 0 comments Download
D skia/ext/convolver.cc View 1 chunk +0 lines, -713 lines 0 comments Download
D skia/ext/convolver_SSE2.h View 1 chunk +0 lines, -27 lines 0 comments Download
D skia/ext/convolver_SSE2.cc View 1 chunk +0 lines, -457 lines 0 comments Download
D skia/ext/convolver_mips_dspr2.h View 1 chunk +0 lines, -25 lines 0 comments Download
D skia/ext/convolver_mips_dspr2.cc View 1 chunk +0 lines, -478 lines 0 comments Download
D skia/ext/convolver_unittest.cc View 1 chunk +0 lines, -532 lines 0 comments Download
D skia/ext/data/vectorcanvastest/basicdrawing/00_pc_clean.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/basicdrawing/00_vc_clean.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/basicdrawing/01_pc_drawargb.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/basicdrawing/01_vc_drawargb.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/basicdrawing/02_pc_drawline_black.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/basicdrawing/02_vc_drawline_black.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/basicdrawing/03_pc_drawrect_green.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/basicdrawing/03_vc_drawrect_green.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/basicdrawing/04_pc_drawrect_noop.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/basicdrawing/04_vc_drawrect_noop.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/basicdrawing/05_pc_drawrect_noop.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/basicdrawing/05_vc_drawrect_noop.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/basicdrawing/06_pc_drawpaint_black.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/basicdrawing/06_vc_drawpaint_black.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/basicdrawing/07_pc_drawline_left_to_right.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/basicdrawing/07_vc_drawline_left_to_right.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/basicdrawing/08_pc_drawline_red.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/basicdrawing/08_vc_drawline_red.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/bitmaps/00_pc_opaque.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/bitmaps/00_vc_opaque.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/bitmaps/01_pc_alpha.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/bitmaps/01_vc_alpha.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/bitmaps/bitmap_alpha.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/bitmaps/bitmap_opaque.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/circles/00_pc_circle_stroke.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/circles/00_vc_circle_stroke.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/circles/01_pc_circle_fill.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/circles/01_vc_circle_fill.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/circles/02_pc_circle_over_strike.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/circles/02_vc_circle_over_strike.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/circles/03_pc_circle_stroke_and_fill.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/circles/03_vc_circle_stroke_and_fill.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/circles/04_pc_mixed_stroke.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/circles/04_vc_mixed_stroke.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/clippingclean/00_pc_clipped.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/clippingclean/00_vc_clipped.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/clippingclean/01_pc_unclipped.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/clippingclean/01_vc_unclipped.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/clippingcombined/00_pc_combined.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/clippingcombined/00_vc_combined.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/clippingintersect/00_pc_intersect.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/clippingintersect/00_vc_intersect.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/clippingpath/00_pc_path.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/clippingpath/00_vc_path.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/clippingrect/00_pc_rect.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/clippingrect/00_vc_rect.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/diagonallines/00_pc_nw-se.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/diagonallines/00_vc_nw-se.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/diagonallines/01_pc_sw-ne.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/diagonallines/01_vc_sw-ne.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/diagonallines/02_pc_ne-sw.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/diagonallines/02_vc_ne-sw.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/diagonallines/03_pc_se-nw.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/diagonallines/03_vc_se-nw.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/lineorientation/00_pc_horizontal.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/lineorientation/00_vc_horizontal.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/lineorientation/01_pc_vertical.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/lineorientation/01_vc_vertical.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/lineorientation/02_pc_horizontal_180.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/lineorientation/02_vc_horizontal_180.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/lineorientation/03_pc_vertical_180.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/lineorientation/03_vc_vertical_180.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/matrix/00_pc_translate1.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/matrix/00_vc_translate1.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/matrix/01_pc_translate2.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/matrix/01_vc_translate2.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/matrix/02_pc_scale.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/matrix/02_vc_scale.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/matrix/03_pc_rotate.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/matrix/03_vc_rotate.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/patheffects/00_pc_dash_line.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/patheffects/00_vc_dash_line.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/patheffects/01_pc_dash_path.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/patheffects/01_vc_dash_path.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/patheffects/02_pc_dash_rect.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/patheffects/02_vc_dash_rect.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/patheffects/03_pc_circle.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/patheffects/03_vc_circle.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/pathorientation/00_pc_drawpath_ltr.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/pathorientation/00_vc_drawpath_ltr.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/pathorientation/01_pc_drawpath_rtl.png View Binary file 0 comments Download
D skia/ext/data/vectorcanvastest/pathorientation/01_vc_drawpath_rtl.png View Binary file 0 comments Download
D skia/ext/fontmgr_default_win.h View 1 chunk +0 lines, -14 lines 0 comments Download
D skia/ext/fontmgr_default_win.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D skia/ext/image_operations.h View 1 chunk +0 lines, -116 lines 0 comments Download
D skia/ext/image_operations.cc View 1 chunk +0 lines, -413 lines 0 comments Download
D skia/ext/image_operations_bench.cc View 1 chunk +0 lines, -290 lines 0 comments Download
D skia/ext/image_operations_unittest.cc View 1 chunk +0 lines, -705 lines 0 comments Download
D skia/ext/pixel_ref_utils.h View 1 chunk +0 lines, -32 lines 0 comments Download
D skia/ext/pixel_ref_utils.cc View 1 chunk +0 lines, -369 lines 0 comments Download
D skia/ext/pixel_ref_utils_unittest.cc View 1 chunk +0 lines, -673 lines 0 comments Download
D skia/ext/recursive_gaussian_convolution.h View 1 chunk +0 lines, -71 lines 0 comments Download
D skia/ext/recursive_gaussian_convolution.cc View 1 chunk +0 lines, -270 lines 0 comments Download
D skia/ext/recursive_gaussian_convolution_unittest.cc View 1 chunk +0 lines, -395 lines 0 comments Download
M ui/android/BUILD.gn View 1 chunk +0 lines, -9 lines 0 comments Download
M ui/gfx/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gfx/android/gfx_jni_registrar.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D ui/gfx/android/java_bitmap.h View 1 chunk +0 lines, -83 lines 0 comments Download
D ui/gfx/android/java_bitmap.cc View 1 chunk +0 lines, -148 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
jamesr
5 years ago (2015-12-11 23:11:54 UTC) #2
kulakowski1
rs lgtm
5 years ago (2015-12-11 23:13:16 UTC) #4
viettrungluu
lgtm too, assuming green bots
5 years ago (2015-12-11 23:21:59 UTC) #5
jamesr
5 years ago (2015-12-11 23:45:41 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
9498ce03c41ba008bc95900130054318aeb7eaa2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698