Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1513543003: [turbofan] Make MachineType a pair of enums. (Closed)

Created:
5 years ago by Jarin
Modified:
5 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, titzer
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Make MachineType a pair of enums. MachineType is now a class with two enum fields: - MachineRepresentation - MachineSemantic Both enums are usable on their own, and this change switches some places from using MachineType to use just MachineRepresentation. Most notably: - register allocator now uses just the representation. - Phi and Select nodes only refer to representations. Committed: https://crrev.com/bb2a830debbff19cf5a510c920ff9ac88d41355c Cr-Commit-Position: refs/heads/master@{#32738}

Patch Set 1 #

Patch Set 2 : Fix mips #

Patch Set 3 : Phi rep #

Patch Set 4 : Fix arm64 #

Patch Set 5 : Make sure we never use OpParameter<MachineType> #

Patch Set 6 : Undo the ppc change #

Patch Set 7 : Tweaks #

Patch Set 8 : Fix mips #

Patch Set 9 : Rebase #

Patch Set 10 : Moar rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4139 lines, -3269 lines) Patch
M src/compiler/access-builder.cc View 32 chunks +62 lines, -49 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 1 2 3 4 6 chunks +36 lines, -37 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 2 3 4 5 6 7 8 6 chunks +40 lines, -41 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 2 5 chunks +10 lines, -7 lines 0 comments Download
M src/compiler/basic-block-instrumentor.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M src/compiler/c-linkage.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/change-lowering.cc View 1 2 15 chunks +30 lines, -27 lines 0 comments Download
M src/compiler/code-generator.cc View 4 chunks +25 lines, -19 lines 0 comments Download
M src/compiler/code-stub-assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/common-operator.h View 1 2 3 4 5 6 3 chunks +9 lines, -6 lines 0 comments Download
M src/compiler/common-operator.cc View 1 2 3 4 5 6 7 chunks +39 lines, -30 lines 0 comments Download
M src/compiler/diamond.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/escape-analysis.cc View 1 2 4 chunks +9 lines, -6 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 2 3 4 8 chunks +43 lines, -42 lines 0 comments Download
M src/compiler/instruction.h View 7 chunks +40 lines, -40 lines 0 comments Download
M src/compiler/instruction.cc View 5 chunks +27 lines, -27 lines 0 comments Download
M src/compiler/instruction-selector.h View 1 chunk +18 lines, -7 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 2 3 4 5 6 7 8 13 chunks +27 lines, -23 lines 0 comments Download
M src/compiler/instruction-selector-impl.h View 7 chunks +17 lines, -16 lines 0 comments Download
M src/compiler/interpreter-assembler.cc View 12 chunks +27 lines, -22 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 2 18 chunks +35 lines, -32 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 1 2 6 chunks +8 lines, -8 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 2 8 chunks +18 lines, -15 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 2 3 4 5 14 chunks +42 lines, -33 lines 0 comments Download
M src/compiler/linkage.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/linkage.cc View 8 chunks +32 lines, -32 lines 0 comments Download
M src/compiler/live-range-separator.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/loop-peeling.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/machine-operator.h View 1 2 3 4 5 6 7 8 4 chunks +9 lines, -6 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 2 3 4 5 6 7 8 10 chunks +43 lines, -48 lines 0 comments Download
M src/compiler/machine-operator-reducer.cc View 1 2 3 4 5 6 6 chunks +21 lines, -15 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 2 3 4 5 6 7 6 chunks +36 lines, -37 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 2 3 4 5 6 7 8 6 chunks +40 lines, -41 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 2 3 4 5 6 7 8 2 chunks +11 lines, -11 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/register-allocator.h View 5 chunks +9 lines, -7 lines 0 comments Download
M src/compiler/register-allocator.cc View 21 chunks +45 lines, -49 lines 0 comments Download
M src/compiler/register-allocator-verifier.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/representation-change.h View 2 chunks +15 lines, -13 lines 0 comments Download
M src/compiler/representation-change.cc View 10 chunks +100 lines, -85 lines 0 comments Download
M src/compiler/select-lowering.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-lowering.cc View 1 2 3 4 5 6 39 chunks +245 lines, -202 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M src/compiler/state-values-utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 2 3 4 5 6 7 8 6 chunks +40 lines, -41 lines 0 comments Download
M src/machine-type.h View 1 2 3 4 5 6 2 chunks +158 lines, -82 lines 0 comments Download
M src/machine-type.cc View 1 chunk +55 lines, -24 lines 0 comments Download
M test/cctest/compiler/c-signature.h View 6 chunks +32 lines, -29 lines 0 comments Download
M test/cctest/compiler/codegen-tester.h View 10 chunks +85 lines, -64 lines 0 comments Download
M test/cctest/compiler/codegen-tester.cc View 15 chunks +29 lines, -20 lines 0 comments Download
M test/cctest/compiler/graph-builder-tester.h View 2 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/compiler/test-basic-block-profiler.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-branch-combine.cc View 12 chunks +15 lines, -13 lines 0 comments Download
M test/cctest/compiler/test-changes-lowering.cc View 7 chunks +14 lines, -14 lines 0 comments Download
M test/cctest/compiler/test-gap-resolver.cc View 3 chunks +19 lines, -18 lines 0 comments Download
M test/cctest/compiler/test-graph-visualizer.cc View 1 2 3 chunks +6 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-jump-threading.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-loop-analysis.cc View 1 2 11 chunks +21 lines, -15 lines 0 comments Download
M test/cctest/compiler/test-machine-operator-reducer.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/compiler/test-multiple-return.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-osr.cc View 1 2 4 chunks +11 lines, -6 lines 0 comments Download
M test/cctest/compiler/test-representation-change.cc View 31 chunks +182 lines, -138 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 2 3 4 5 6 7 8 9 209 chunks +394 lines, -322 lines 0 comments Download
M test/cctest/compiler/test-run-native-calls.cc View 8 chunks +46 lines, -34 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 2 3 4 5 6 65 chunks +144 lines, -132 lines 0 comments Download
M test/unittests/compiler/arm/instruction-selector-arm-unittest.cc View 141 chunks +248 lines, -160 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 1 2 3 133 chunks +321 lines, -226 lines 0 comments Download
M test/unittests/compiler/branch-elimination-unittest.cc View 1 2 6 chunks +22 lines, -17 lines 0 comments Download
M test/unittests/compiler/change-lowering-unittest.cc View 1 2 25 chunks +87 lines, -66 lines 0 comments Download
M test/unittests/compiler/common-operator-reducer-unittest.cc View 1 2 25 chunks +56 lines, -46 lines 0 comments Download
M test/unittests/compiler/common-operator-unittest.cc View 1 2 1 chunk +10 lines, -7 lines 0 comments Download
M test/unittests/compiler/control-flow-optimizer-unittest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/dead-code-elimination-unittest.cc View 1 2 8 chunks +19 lines, -17 lines 0 comments Download
M test/unittests/compiler/diamond-unittest.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M test/unittests/compiler/escape-analysis-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/ia32/instruction-selector-ia32-unittest.cc View 34 chunks +55 lines, -43 lines 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.h View 3 chunks +11 lines, -7 lines 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.cc View 1 2 19 chunks +56 lines, -51 lines 0 comments Download
M test/unittests/compiler/interpreter-assembler-unittest.cc View 15 chunks +61 lines, -47 lines 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M test/unittests/compiler/js-context-relaxation-unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/unittests/compiler/js-intrinsic-lowering-unittest.cc View 1 2 8 chunks +12 lines, -10 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M test/unittests/compiler/linkage-tail-call-unittest.cc View 2 chunks +16 lines, -14 lines 0 comments Download
M test/unittests/compiler/live-range-builder.h View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/live-range-unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M test/unittests/compiler/liveness-analyzer-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/loop-peeling-unittest.cc View 1 2 9 chunks +26 lines, -24 lines 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 1 2 9 chunks +18 lines, -14 lines 0 comments Download
M test/unittests/compiler/machine-operator-unittest.cc View 10 chunks +36 lines, -26 lines 0 comments Download
M test/unittests/compiler/mips/instruction-selector-mips-unittest.cc View 1 41 chunks +144 lines, -110 lines 0 comments Download
M test/unittests/compiler/mips64/instruction-selector-mips64-unittest.cc View 1 2 60 chunks +177 lines, -135 lines 0 comments Download
M test/unittests/compiler/move-optimizer-unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 2 3 4 5 6 14 chunks +26 lines, -25 lines 0 comments Download
M test/unittests/compiler/scheduler-unittest.cc View 1 2 16 chunks +48 lines, -28 lines 0 comments Download
M test/unittests/compiler/select-lowering-unittest.cc View 1 2 2 chunks +11 lines, -9 lines 0 comments Download
M test/unittests/compiler/simplified-operator-unittest.cc View 1 chunk +26 lines, -23 lines 0 comments Download
M test/unittests/compiler/tail-call-optimization-unittest.cc View 6 chunks +18 lines, -12 lines 0 comments Download
M test/unittests/compiler/x64/instruction-selector-x64-unittest.cc View 72 chunks +122 lines, -82 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Jarin
Could you take a look, please?
5 years ago (2015-12-10 08:28:20 UTC) #3
Benedikt Meurer
Awesome, LGTM.
5 years ago (2015-12-10 09:00:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513543003/170001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513543003/170001
5 years ago (2015-12-10 09:01:00 UTC) #6
commit-bot: I haz the power
Committed patchset #10 (id:170001)
5 years ago (2015-12-10 09:03:38 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-10 09:03:59 UTC) #10
Message was sent while issue was closed.
Patchset 10 (id:??) landed as
https://crrev.com/bb2a830debbff19cf5a510c920ff9ac88d41355c
Cr-Commit-Position: refs/heads/master@{#32738}

Powered by Google App Engine
This is Rietveld 408576698