Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: test/unittests/compiler/js-intrinsic-lowering-unittest.cc

Issue 1513543003: [turbofan] Make MachineType a pair of enums. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Moar rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/unittests/compiler/js-intrinsic-lowering-unittest.cc
diff --git a/test/unittests/compiler/js-intrinsic-lowering-unittest.cc b/test/unittests/compiler/js-intrinsic-lowering-unittest.cc
index 5663086c1d0ea1ea3742644f4202b02ea0a0e4d6..2b829fdca54eacf0903b1cc4d65f0a3573f8e143 100644
--- a/test/unittests/compiler/js-intrinsic-lowering-unittest.cc
+++ b/test/unittests/compiler/js-intrinsic-lowering-unittest.cc
@@ -32,7 +32,8 @@ class JSIntrinsicLoweringTest : public TypedGraphTest {
protected:
Reduction Reduce(Node* node, MachineOperatorBuilder::Flags flags =
MachineOperatorBuilder::kNoFlags) {
- MachineOperatorBuilder machine(zone(), kMachPtr, flags);
+ MachineOperatorBuilder machine(zone(), MachineType::PointerRepresentation(),
+ flags);
SimplifiedOperatorBuilder simplified(zone());
JSGraph jsgraph(isolate(), graph(), common(), javascript(), &simplified,
&machine);
@@ -148,7 +149,7 @@ TEST_F(JSIntrinsicLoweringTest, InlineIsArray) {
EXPECT_THAT(
phi,
IsPhi(
- static_cast<MachineType>(kTypeBool | kRepTagged), IsFalseConstant(),
+ MachineRepresentation::kTagged, IsFalseConstant(),
IsWord32Equal(IsLoadField(AccessBuilder::ForMapInstanceType(),
IsLoadField(AccessBuilder::ForMap(), input,
effect, CaptureEq(&if_false)),
@@ -179,7 +180,7 @@ TEST_F(JSIntrinsicLoweringTest, InlineIsDate) {
EXPECT_THAT(
phi,
IsPhi(
- static_cast<MachineType>(kTypeBool | kRepTagged), IsFalseConstant(),
+ MachineRepresentation::kTagged, IsFalseConstant(),
IsWord32Equal(IsLoadField(AccessBuilder::ForMapInstanceType(),
IsLoadField(AccessBuilder::ForMap(), input,
effect, CaptureEq(&if_false)),
@@ -210,7 +211,7 @@ TEST_F(JSIntrinsicLoweringTest, InlineIsTypedArray) {
EXPECT_THAT(
phi,
IsPhi(
- static_cast<MachineType>(kTypeBool | kRepTagged), IsFalseConstant(),
+ MachineRepresentation::kTagged, IsFalseConstant(),
IsWord32Equal(IsLoadField(AccessBuilder::ForMapInstanceType(),
IsLoadField(AccessBuilder::ForMap(), input,
effect, CaptureEq(&if_false)),
@@ -241,7 +242,7 @@ TEST_F(JSIntrinsicLoweringTest, InlineIsFunction) {
EXPECT_THAT(
phi,
IsPhi(
- static_cast<MachineType>(kTypeBool | kRepTagged), IsFalseConstant(),
+ MachineRepresentation::kTagged, IsFalseConstant(),
IsWord32Equal(IsLoadField(AccessBuilder::ForMapInstanceType(),
IsLoadField(AccessBuilder::ForMap(), input,
effect, CaptureEq(&if_false)),
@@ -272,7 +273,7 @@ TEST_F(JSIntrinsicLoweringTest, InlineIsRegExp) {
EXPECT_THAT(
phi,
IsPhi(
- static_cast<MachineType>(kTypeBool | kRepTagged), IsFalseConstant(),
+ MachineRepresentation::kTagged, IsFalseConstant(),
IsWord32Equal(IsLoadField(AccessBuilder::ForMapInstanceType(),
IsLoadField(AccessBuilder::ForMap(), input,
effect, CaptureEq(&if_false)),
@@ -303,7 +304,7 @@ TEST_F(JSIntrinsicLoweringTest, InlineIsJSReceiverWithAny) {
EXPECT_THAT(
phi,
IsPhi(
- kMachAnyTagged, IsFalseConstant(),
+ MachineRepresentation::kTagged, IsFalseConstant(),
IsUint32LessThanOrEqual(
IsInt32Constant(FIRST_JS_RECEIVER_TYPE),
IsLoadField(AccessBuilder::ForMapInstanceType(),
@@ -449,9 +450,10 @@ TEST_F(JSIntrinsicLoweringTest, InlineValueOf) {
EXPECT_THAT(
phi,
IsPhi(
- kMachAnyTagged, input,
- IsPhi(kMachAnyTagged, IsLoadField(AccessBuilder::ForValue(), input,
- effect, CaptureEq(&if_true1)),
+ MachineRepresentation::kTagged, input,
+ IsPhi(MachineRepresentation::kTagged,
+ IsLoadField(AccessBuilder::ForValue(), input, effect,
+ CaptureEq(&if_true1)),
input,
IsMerge(
AllOf(CaptureEq(&if_true1), IsIfTrue(CaptureEq(&branch1))),
« no previous file with comments | « test/unittests/compiler/js-context-relaxation-unittest.cc ('k') | test/unittests/compiler/js-typed-lowering-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698