Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: test/unittests/compiler/common-operator-unittest.cc

Issue 1513543003: [turbofan] Make MachineType a pair of enums. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Moar rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/unittests/compiler/common-operator-unittest.cc
diff --git a/test/unittests/compiler/common-operator-unittest.cc b/test/unittests/compiler/common-operator-unittest.cc
index 64c5f73d273118858ec49d864fd5ea20514d53d0..0a55a2e2a2d4659d62fdebdf8371fc5b565f8a19 100644
--- a/test/unittests/compiler/common-operator-unittest.cc
+++ b/test/unittests/compiler/common-operator-unittest.cc
@@ -272,16 +272,19 @@ TEST_F(CommonOperatorTest, IfValue) {
TEST_F(CommonOperatorTest, Select) {
- static const MachineType kTypes[] = {
- kMachInt8, kMachUint8, kMachInt16, kMachUint16,
- kMachInt32, kMachUint32, kMachInt64, kMachUint64,
- kMachFloat32, kMachFloat64, kMachAnyTagged};
- TRACED_FOREACH(MachineType, type, kTypes) {
+ static const MachineRepresentation kMachineRepresentations[] = {
+ MachineRepresentation::kBit, MachineRepresentation::kWord8,
+ MachineRepresentation::kWord16, MachineRepresentation::kWord32,
+ MachineRepresentation::kWord64, MachineRepresentation::kFloat32,
+ MachineRepresentation::kFloat64, MachineRepresentation::kTagged};
+
+
+ TRACED_FOREACH(MachineRepresentation, rep, kMachineRepresentations) {
TRACED_FOREACH(BranchHint, hint, kBranchHints) {
- const Operator* const op = common()->Select(type, hint);
+ const Operator* const op = common()->Select(rep, hint);
EXPECT_EQ(IrOpcode::kSelect, op->opcode());
EXPECT_EQ(Operator::kPure, op->properties());
- EXPECT_EQ(type, SelectParametersOf(op).type());
+ EXPECT_EQ(rep, SelectParametersOf(op).representation());
EXPECT_EQ(hint, SelectParametersOf(op).hint());
EXPECT_EQ(3, op->ValueInputCount());
EXPECT_EQ(0, op->EffectInputCount());

Powered by Google App Engine
This is Rietveld 408576698