[turbofan] Make MachineType a pair of enums.

test/unittests/compiler/js-intrinsic-lowering-unittest.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/access-builder.h"
 #include "src/compiler/diamond.h"
 #include "src/compiler/js-graph.h"
 #include "src/compiler/js-intrinsic-lowering.h"
 #include "src/compiler/js-operator.h"
 #include "src/types-inl.h"
@@ skipping 14 matching lines @@
 namespace compiler {
 
 class JSIntrinsicLoweringTest : public TypedGraphTest {
  public:
   JSIntrinsicLoweringTest() : TypedGraphTest(3), javascript_(zone()) {}
   ~JSIntrinsicLoweringTest() override {}
 
  protected:
   Reduction Reduce(Node* node, MachineOperatorBuilder::Flags flags =
                                    MachineOperatorBuilder::kNoFlags) {
-    MachineOperatorBuilder machine(zone(), kMachPtr, flags);
+    MachineOperatorBuilder machine(zone(), MachineType::PointerRepresentation(),
+                                   flags);
     SimplifiedOperatorBuilder simplified(zone());
     JSGraph jsgraph(isolate(), graph(), common(), javascript(), &simplified,
                     &machine);
     // TODO(titzer): mock the GraphReducer here for better unit testing.
     GraphReducer graph_reducer(zone(), graph());
     JSIntrinsicLowering reducer(&graph_reducer, &jsgraph,
                                 JSIntrinsicLowering::kDeoptimizationEnabled);
     return reducer.Reduce(node);
   }
 
@@ skipping 95 matching lines @@
   Reduction const r = Reduce(
       graph()->NewNode(javascript()->CallRuntime(Runtime::kInlineIsArray, 1),
                        input, context, effect, control));
   ASSERT_TRUE(r.Changed());
 
   Node* phi = r.replacement();
   Capture<Node*> branch, if_false;
   EXPECT_THAT(
       phi,
       IsPhi(
-          static_cast<MachineType>(kTypeBool | kRepTagged), IsFalseConstant(),
+          MachineRepresentation::kTagged, IsFalseConstant(),
           IsWord32Equal(IsLoadField(AccessBuilder::ForMapInstanceType(),
                                     IsLoadField(AccessBuilder::ForMap(), input,
                                                 effect, CaptureEq(&if_false)),
                                     effect, _),
                         IsInt32Constant(JS_ARRAY_TYPE)),
           IsMerge(IsIfTrue(AllOf(CaptureEq(&branch),
                                  IsBranch(IsObjectIsSmi(input), control))),
                   AllOf(CaptureEq(&if_false), IsIfFalse(CaptureEq(&branch))))));
 }
 
@@ skipping 10 matching lines @@
   Reduction const r = Reduce(
       graph()->NewNode(javascript()->CallRuntime(Runtime::kInlineIsDate, 1),
                        input, context, effect, control));
   ASSERT_TRUE(r.Changed());
 
   Node* phi = r.replacement();
   Capture<Node*> branch, if_false;
   EXPECT_THAT(
       phi,
       IsPhi(
-          static_cast<MachineType>(kTypeBool | kRepTagged), IsFalseConstant(),
+          MachineRepresentation::kTagged, IsFalseConstant(),
           IsWord32Equal(IsLoadField(AccessBuilder::ForMapInstanceType(),
                                     IsLoadField(AccessBuilder::ForMap(), input,
                                                 effect, CaptureEq(&if_false)),
                                     effect, _),
                         IsInt32Constant(JS_DATE_TYPE)),
           IsMerge(IsIfTrue(AllOf(CaptureEq(&branch),
                                  IsBranch(IsObjectIsSmi(input), control))),
                   AllOf(CaptureEq(&if_false), IsIfFalse(CaptureEq(&branch))))));
 }
 
@@ skipping 10 matching lines @@
   Reduction const r = Reduce(graph()->NewNode(
       javascript()->CallRuntime(Runtime::kInlineIsTypedArray, 1), input,
       context, effect, control));
   ASSERT_TRUE(r.Changed());
 
   Node* phi = r.replacement();
   Capture<Node*> branch, if_false;
   EXPECT_THAT(
       phi,
       IsPhi(
-          static_cast<MachineType>(kTypeBool | kRepTagged), IsFalseConstant(),
+          MachineRepresentation::kTagged, IsFalseConstant(),
           IsWord32Equal(IsLoadField(AccessBuilder::ForMapInstanceType(),
                                     IsLoadField(AccessBuilder::ForMap(), input,
                                                 effect, CaptureEq(&if_false)),
                                     effect, _),
                         IsInt32Constant(JS_TYPED_ARRAY_TYPE)),
           IsMerge(IsIfTrue(AllOf(CaptureEq(&branch),
                                  IsBranch(IsObjectIsSmi(input), control))),
                   AllOf(CaptureEq(&if_false), IsIfFalse(CaptureEq(&branch))))));
 }
 
@@ skipping 10 matching lines @@
   Reduction const r = Reduce(
       graph()->NewNode(javascript()->CallRuntime(Runtime::kInlineIsFunction, 1),
                        input, context, effect, control));
   ASSERT_TRUE(r.Changed());
 
   Node* phi = r.replacement();
   Capture<Node*> branch, if_false;
   EXPECT_THAT(
       phi,
       IsPhi(
-          static_cast<MachineType>(kTypeBool | kRepTagged), IsFalseConstant(),
+          MachineRepresentation::kTagged, IsFalseConstant(),
           IsWord32Equal(IsLoadField(AccessBuilder::ForMapInstanceType(),
                                     IsLoadField(AccessBuilder::ForMap(), input,
                                                 effect, CaptureEq(&if_false)),
                                     effect, _),
                         IsInt32Constant(JS_FUNCTION_TYPE)),
           IsMerge(IsIfTrue(AllOf(CaptureEq(&branch),
                                  IsBranch(IsObjectIsSmi(input), control))),
                   AllOf(CaptureEq(&if_false), IsIfFalse(CaptureEq(&branch))))));
 }
 
@@ skipping 10 matching lines @@
   Reduction const r = Reduce(
       graph()->NewNode(javascript()->CallRuntime(Runtime::kInlineIsRegExp, 1),
                        input, context, effect, control));
   ASSERT_TRUE(r.Changed());
 
   Node* phi = r.replacement();
   Capture<Node*> branch, if_false;
   EXPECT_THAT(
       phi,
       IsPhi(
-          static_cast<MachineType>(kTypeBool | kRepTagged), IsFalseConstant(),
+          MachineRepresentation::kTagged, IsFalseConstant(),
           IsWord32Equal(IsLoadField(AccessBuilder::ForMapInstanceType(),
                                     IsLoadField(AccessBuilder::ForMap(), input,
                                                 effect, CaptureEq(&if_false)),
                                     effect, _),
                         IsInt32Constant(JS_REGEXP_TYPE)),
           IsMerge(IsIfTrue(AllOf(CaptureEq(&branch),
                                  IsBranch(IsObjectIsSmi(input), control))),
                   AllOf(CaptureEq(&if_false), IsIfFalse(CaptureEq(&branch))))));
 }
 
@@ skipping 10 matching lines @@
   Reduction const r = Reduce(graph()->NewNode(
       javascript()->CallRuntime(Runtime::kInlineIsJSReceiver, 1), input,
       context, effect, control));
   ASSERT_TRUE(r.Changed());
 
   Node* phi = r.replacement();
   Capture<Node *> branch, if_false;
   EXPECT_THAT(
       phi,
       IsPhi(
-          kMachAnyTagged, IsFalseConstant(),
+          MachineRepresentation::kTagged, IsFalseConstant(),
           IsUint32LessThanOrEqual(
               IsInt32Constant(FIRST_JS_RECEIVER_TYPE),
               IsLoadField(AccessBuilder::ForMapInstanceType(),
                           IsLoadField(AccessBuilder::ForMap(), input, effect,
                                       CaptureEq(&if_false)),
                           effect, _)),
           IsMerge(IsIfTrue(AllOf(CaptureEq(&branch),
                                  IsBranch(IsObjectIsSmi(input), control))),
                   AllOf(CaptureEq(&if_false), IsIfFalse(CaptureEq(&branch))))));
 }
@@ skipping 125 matching lines @@
   Reduction const r = Reduce(
       graph()->NewNode(javascript()->CallRuntime(Runtime::kInlineValueOf, 1),
                        input, context, effect, control));
   ASSERT_TRUE(r.Changed());
 
   Node* phi = r.replacement();
   Capture<Node*> branch0, if_false0, branch1, if_true1;
   EXPECT_THAT(
       phi,
       IsPhi(
-          kMachAnyTagged, input,
-          IsPhi(kMachAnyTagged, IsLoadField(AccessBuilder::ForValue(), input,
-                                            effect, CaptureEq(&if_true1)),
+          MachineRepresentation::kTagged, input,
+          IsPhi(MachineRepresentation::kTagged,
+                IsLoadField(AccessBuilder::ForValue(), input, effect,
+                            CaptureEq(&if_true1)),
                 input,
                 IsMerge(
                     AllOf(CaptureEq(&if_true1), IsIfTrue(CaptureEq(&branch1))),
                     IsIfFalse(AllOf(
                         CaptureEq(&branch1),
                         IsBranch(
                             IsWord32Equal(
                                 IsLoadField(
                                     AccessBuilder::ForMapInstanceType(),
                                     IsLoadField(AccessBuilder::ForMap(), input,
                                                 effect, CaptureEq(&if_false0)),
                                     effect, _),
                                 IsInt32Constant(JS_VALUE_TYPE)),
                             CaptureEq(&if_false0)))))),
           IsMerge(
               IsIfTrue(AllOf(CaptureEq(&branch0),
                              IsBranch(IsObjectIsSmi(input), control))),
               AllOf(CaptureEq(&if_false0), IsIfFalse(CaptureEq(&branch0))))));
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8